Re: if(function()) BUG(); still bad?

[Matthew Wilcox <matthew@wil.cx>]

On Mon, Dec 03, 2007 at 02:18:35AM +0100, Adrian Bunk wrote:
> On Sun, Dec 02, 2007 at 05:32:22PM -0700, Matthew Wilcox wrote:
> > On Mon, Dec 03, 2007 at 01:20:20AM +0100, Roel Kluin wrote:
> > > for instance in a patch I saw this:
> > > 
> > > > +		if (__blk_end_request(rq, 0, 0))
> > > > +			BUG();
> > 
> > This one should not be converted to a BUG_ON.  We always want to call
> > __blk_end_request(), whether we have CONFIG_BUG or not.  This case just
> > wants to test the return value.
> 
> It can be converted, the empty BUG_ON() in include/asm-generic/bug.h 
> handles it with
> 
>   #define BUG_ON(condition) do { if (condition) ; } while(0)

Yes, but it gives the wrong impression.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."