diff for duplicates of <20071203145443.GE15034@ghostprotocols.net> diff --git a/a/1.txt b/N1/1.txt index c957a11..78df7e7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -41,7 +41,7 @@ yours :-) > | + > | + for (i = 0; i <= NDUPACK; i++) { > | + h->ring[i] = kmem_cache_alloc(tfrc_rxh_cache, GFP_ATOMIC); -> | + if (h->ring[i] = NULL) +> | + if (h->ring[i] == NULL) > | + return 1; > | + } > | + h->loss_count = 0; @@ -60,7 +60,7 @@ yours :-) > { > h->ring = kmem_cache_alloc(tfrc_rx_hist_slab, GFP_ATOMIC); > h->loss_count = h->loss_start = 0; -> return h->ring = NULL; +> return h->ring == NULL; > } > > which is better not only for one but for two reasons. It solves the leakage and in addition makes @@ -89,7 +89,7 @@ great > | > // ... > | > u32 sample, payload_size = skb->len - dccp_hdr(skb)->dccph_doff * 4; > | > -> | > if (unlikely(hcrx->ccid3hcrx_state = TFRC_RSTATE_NO_DATA)) { +> | > if (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) { > | > if (is_data_packet) { > | > do_feedback = FBACK_INITIAL; > | > ccid3_hc_rx_set_state(sk, TFRC_RSTATE_DATA); @@ -98,7 +98,7 @@ great > | > goto update_records; > | > } > | > -> | > => Non-data packets are ignored for the purposes of computing s (this is in the RFC), +> | > ==> Non-data packets are ignored for the purposes of computing s (this is in the RFC), > | > consequently update_s() is only called for data packets; using the two following > | > functions: > | > diff --git a/a/content_digest b/N1/content_digest index fadf072..858d2e8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,15 @@ "ref\01196631416-17778-1-git-send-email-acme@redhat.com\0" + "ref\020071203083512.GA5484@gerrit.erg.abdn.ac.uk\0" + "ref\020071203124412.GC15034@ghostprotocols.net\0" + "ref\020071203134947.GD18547@gerrit.erg.abdn.ac.uk\0" "From\0Arnaldo Carvalho de Melo <acme@redhat.com>\0" "Subject\0Re: [RFC][PATCHES 0/7]: Reorganization of RX history patches\0" - "Date\0Mon, 03 Dec 2007 14:54:43 +0000\0" - "To\0dccp@vger.kernel.org\0" + "Date\0Mon, 3 Dec 2007 12:54:43 -0200\0" + "To\0Gerrit Renker <gerrit@erg.abdn.ac.uk>" + Arnaldo Carvalho de Melo <acme@redhat.com> + netdev@vger.kernel.org + dccp@vger.kernel.org + " Ingo Molnar <mingo@elte.hu>\0" "\00:1\0" "b\0" "Em Mon, Dec 03, 2007 at 01:49:47PM +0000, Gerrit Renker escreveu:\n" @@ -48,7 +55,7 @@ "> | +\n" "> | +\tfor (i = 0; i <= NDUPACK; i++) {\n" "> | +\t\th->ring[i] = kmem_cache_alloc(tfrc_rxh_cache, GFP_ATOMIC);\n" - "> | +\t\tif (h->ring[i] = NULL)\n" + "> | +\t\tif (h->ring[i] == NULL)\n" "> | +\t\t\treturn 1;\n" "> | +\t}\n" "> | +\th->loss_count = 0;\n" @@ -67,7 +74,7 @@ "> \t{\n" "> \t\th->ring = kmem_cache_alloc(tfrc_rx_hist_slab, GFP_ATOMIC);\n" "> \t\th->loss_count = h->loss_start = 0;\n" - "> \t\treturn h->ring = NULL;\n" + "> \t\treturn h->ring == NULL;\n" "> \t}\n" "> \n" "> which is better not only for one but for two reasons. It solves the leakage and in addition makes\n" @@ -96,7 +103,7 @@ "> | > \t\t// ...\n" "> | > \t\tu32 sample, payload_size = skb->len - dccp_hdr(skb)->dccph_doff * 4;\n" "> | > \n" - "> | > \t\tif (unlikely(hcrx->ccid3hcrx_state = TFRC_RSTATE_NO_DATA)) {\n" + "> | > \t\tif (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) {\n" "> | > \t\t\tif (is_data_packet) {\n" "> | > \t\t\t\tdo_feedback = FBACK_INITIAL;\n" "> | > \t\t\t\tccid3_hc_rx_set_state(sk, TFRC_RSTATE_DATA);\n" @@ -105,7 +112,7 @@ "> | > \t\t\tgoto update_records;\n" "> | > \t\t}\n" "> | > \n" - "> | > => Non-data packets are ignored for the purposes of computing s (this is in the RFC),\n" + "> | > ==> Non-data packets are ignored for the purposes of computing s (this is in the RFC),\n" "> | > consequently update_s() is only called for data packets; using the two following\n" "> | > functions:\n" "> | > \n" @@ -235,4 +242,4 @@ "\n" - Arnaldo -98ed4ce86b681e85f0c8e660418776c86513082179e2385dcb1b3bc85b36df8d +dbe9d1b534153514fc296ffc08a86fc99801f85f3ea8fdbe7209fdbdca513650
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.