Re: [RFC,PATCH 7/8] rdma: makefile

["J. Bruce Fields" <bfields@fieldses.org>]

On Mon, Dec 03, 2007 at 11:24:59AM -0600, Tom Tucker wrote:
> I don't know that it adds much, but perhaps for consistency?

It's arguably a little friendlier for someone just learning their way
around the code--the rdma files are probably clutter to them on a first
pass.

> In fact, if we were to move it, would we move it to the same directory
> as the client?

That's what the gss code does, so I guess there's precedent.

No real strong opinion from me, though.

--b.

> 
> On Mon, 2007-12-03 at 12:00 -0500, Chuck Lever wrote:
> > On Nov 29, 2007, at 5:45 PM, Tom Tucker wrote:
> > > Add the NFSD_RDMA module to the sunrpc makefile.
> > 
> > General question about how the RPC level RDMA code is organized:  The  
> > client-side RDMA service provider lives in its own subdirectory of  
> > net/sunrpc.  Should the server side provider also live in that  
> > directory?  Should these two be glued together into a single module?
> > 
> > > Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
> > > ---
> > >
> > >  net/sunrpc/Makefile |    4 ++++
> > >  1 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/net/sunrpc/Makefile b/net/sunrpc/Makefile
> > > index 92e1dbe..6d03dbf 100644
> > > --- a/net/sunrpc/Makefile
> > > +++ b/net/sunrpc/Makefile
> > > @@ -15,3 +15,7 @@ sunrpc-y := clnt.o xprt.o socklib.o xprtsock.o  
> > > sched.o \
> > >  	    svc_xprt.o
> > >  sunrpc-$(CONFIG_PROC_FS) += stats.o
> > >  sunrpc-$(CONFIG_SYSCTL) += sysctl.o
> > > +
> > > +obj-$(CONFIG_NFSD_RDMA) += svcrdma.o
> > > +svcrdma-y := svc_rdma.o svc_rdma_transport.o \
> > > +	svc_rdma_marshal.o svc_rdma_sendto.o svc_rdma_recvfrom.o
> > 
> > 
> > --
> > Chuck Lever
> > chuck[dot]lever[at]oracle[dot]com
>