Re: add rules for new aoe character devices

[Matthias Schwarzott <zzam@gentoo.org>]

On Montag, 3. Dezember 2007, Kay Sievers wrote:
> On Mon, 2007-12-03 at 13:38 -0500, Ed L. Cashin wrote:
> > On Mon, Dec 03, 2007 at 07:15:03PM +0100, Kay Sievers wrote:
> > > On Nov 29, 2007 6:11 PM, Ed L. Cashin <ecashin@coraid.com> wrote:
> > > > The patch below adds support for new aoe driver character "flush" and
> > > > "revalidate" devices to the existing aoe rules in udev-117.
> > > >
> > > > The current aoe driver version in the Linux kernel does not include
> > > > the "flush" feature, but I have already submitted patches to the LKML
> > > > adding that support and am now working on updating those patches for
> > > > resubmission.  Those using the aoe driver on the Coraid website
> > > > already have the "flush" feature.
> > >
> > > The distro rules are just a copy from the distro packages and changes
> > > made here will not get into the packages. We can add the rules only to
> > > the "default" rules.
> >
> > Ah.  Thank you.
> >
> > > Does this rule work for you? It should move all nodes into a subdir:
> > >   SUBSYSTEM="aoe",              NAME="etherd/%k"
> >
> > Yes, that's good for the block devices.  In the past it seems that
> > rule doesn't guarantee the creation of the character device nodes,
> > though, and that is why there is a separate rule for each character
> > node in the patch I sent.  I haven't checked yet whether the latest
> > udev and kernel still behave the same way.
>
> Block devices always have SUBSYSTEM="block", this will only handle the
> char devices. You want the block devices to be in a subdir?
>
> Kay

The rules we had in the old gentoo rules file seems to care only about the aoe 
char-devices.
# aoe char devices,
SUBSYSTEM="aoe", KERNEL="discover",	NAME="etherd/%k", GROUP="disk", 
MODE="0220"
SUBSYSTEM="aoe", KERNEL="err",	NAME="etherd/%k", GROUP="disk", MODE="0440"
SUBSYSTEM="aoe", KERNEL="interfaces",	NAME="etherd/%k", GROUP="disk", 
MODE="0220"


So I also suggest to add something like
SUBSYSTEM="aoe", NAME="etherd/%k", GROUP="disk"

No idea if MODE is really needed like done in the old rules.
As I think: If the drivers are written properly they should only allow reading 
or writing (as needed) without setting it like above.
I suggest to add GROUP=disk as I think these control devices are similar to 
raw sg, raw and tape devices.

Matthias


-- 
Matthias Schwarzott (zzam)


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel