From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Krzysztof B??aszkowski <kb@sysmikro.com.pl>,
linux-scsi@vger.kernel.org, vst@vlnb.net,
Alexis Bruemmer <alexisb@us.ibm.com>
Subject: Re: aic94xx or libsas crash on X7DB3 supermicro with enclosure and sata drives
Date: Mon, 3 Dec 2007 13:31:48 -0800 [thread overview]
Message-ID: <20071203213148.GC7066@tree.beaverton.ibm.com> (raw)
In-Reply-To: <47545C4D.1070708@garzik.org>
On Mon, Dec 03, 2007 at 02:43:09PM -0500, Jeff Garzik wrote:
> But what do you mean by "device removal code can get hung up"? That sounds
> like a bug we should fix.
At the moment, libsas' sas_rphy_remove function doesn't distinguish between
removing a device before or after the disk has been disconnected.
Hence, sd_shutdown tries to tell the disk to flush the write cache, even
in the case that the disk is already gone. Maybe the solution is to
modify aic94xx to remove the device's DDB registration prior to sending
the "device gone" event to libsas so that all subsequent commands bounce
with "no such device" instead of going out to lunch.
(I'll look into this later, as I myself am going out to lunch right now.)
--D
next prev parent reply other threads:[~2007-12-03 21:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 9:22 aic94xx or libsas crash on X7DB3 supermicro with enclosure and sata drives Krzysztof Błaszkowski
2007-11-30 21:33 ` Darrick J. Wong
2007-12-03 15:11 ` Krzysztof Błaszkowski
2007-12-03 16:09 ` Krzysztof Błaszkowski
2007-12-03 19:36 ` Darrick J. Wong
2007-12-03 19:43 ` Jeff Garzik
2007-12-03 21:31 ` Darrick J. Wong [this message]
2007-12-03 20:06 ` Krzysztof Błaszkowski
2007-12-04 22:35 ` [PATCH] libsas: Don't issue commands to devices that have been hot-removed Darrick J. Wong
2007-12-04 22:48 ` Jeff Garzik
2007-12-04 23:17 ` Darrick J. Wong
2007-12-04 23:40 ` Jeff Garzik
2007-12-06 16:55 ` Brian King
2008-02-25 23:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203213148.GC7066@tree.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=alexisb@us.ibm.com \
--cc=jeff@garzik.org \
--cc=kb@sysmikro.com.pl \
--cc=linux-scsi@vger.kernel.org \
--cc=vst@vlnb.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.