All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: linux-wireless <linux-wireless@vger.kernel.org>
Cc: libertas-dev@lists.infradead.org
Subject: questions regarding removing the depencency on CONFIG_IEEE80211
Date: Tue, 4 Dec 2007 11:40:07 +0100	[thread overview]
Message-ID: <200712041140.07516.hs4233@mail.mn-solutions.de> (raw)

Last friday I was asked on IRC about the dependency of libertas 
on CONFIG_IEEE80211. I gave a quick question, but today I had 
time to look into this further.


1. simply things

* remove "select IEEE80211" in wireless/KConfig
* remove "#include <net/ieee80211.h>"


2. MAX_WPA_IE_LEN

This was defined in net/ieee80211.h, but is not defined in 
linux/ieee80211.h. I have two options, which one should I go:

* define it locally in some libertas header file
* define it as IEEE80211_MAX_WPA_IE_LEN in linux/ieee80211.h


3. MAX_NETWORK_COUNT

libertas has a list of found BSSses during scanning. It keeps 
them in an kzalloc()'ed array. However, it doesn't use any of
ieee80211's code for BSS or associating, so I guess I make this a 
private define, e.g. LBS_MAX_BSS_COUNT.


4. DEFAULT_MAX_SCAN_AGE

Again, libertas doesn't use any aging code from ieee80211, so I 
guess I make this a libertas-private define.


5. MFIE_TYPE_xxxx enum

They are easily substituded with the proper WLAN_EID_xxx ones.


6. struct ieee80211_info_element

In scan.c, libertas uses heavily the "struct 
ieee80211_info_element". As this struct might be useful for 
other non-max80211 drivers, I'd suggest putting it in 
include/linux/ieee80211.h.


7. RADIOTAP

Libertas contains lot's of code for it's monitoring mode, which 
uses radiotap. It used "struct net_device *rtap_net_dev" 
and "struct ieee80211_device *ieee". It contains code like

   priv->rtap_net_dev = alloc_ieee80211(0);
   priv->ieee = netdev_priv(priv->rtap_net_dev);

and I don't have any knowledge about radiotap and how to 
substitue the alloc_ieee80211(). All I could currently to is to 
put those sections into #ifdef CONFIG_IEEE80211.

             reply	other threads:[~2007-12-04 10:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-04 10:40 Holger Schurig [this message]
2007-12-04 10:53 ` questions regarding removing the depencency on CONFIG_IEEE80211 Holger Schurig
2007-12-04 14:56   ` Dan Williams
2007-12-04 15:25     ` John W. Linville
2007-12-04 15:29       ` Dan Williams
2007-12-04 15:54         ` Holger Schurig
2007-12-04 16:59         ` Johannes Berg
2007-12-04 17:10           ` Dan Williams
2007-12-04 16:58       ` Johannes Berg
2007-12-04 15:04 ` Dan Williams
2007-12-04 15:47   ` Holger Schurig
2007-12-04 15:56     ` Dan Williams
2007-12-04 16:57 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712041140.07516.hs4233@mail.mn-solutions.de \
    --to=hs4233@mail.mn-solutions.de \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.