From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] pwmconfig patch
Date: Tue, 04 Dec 2007 10:41:54 +0000 [thread overview]
Message-ID: <20071204114154.41279fbc@hyperion.delvare> (raw)
Sorry for the late answer ;)
On Sun, 18 Mar 2007 15:32:02 -0400, Straterra wrote:
> I have a Shuttle SN25P and like most shuttles, all of the fans in it
> are controlled via PWM. I recently tried pwmconfig to set them up for
> automatic speed control and found that there was an issue in the lm85
> driver that has been known, but not fixed. Hopefully, this patch will
> generate enough of a stir that people with the broken driver will
> email and nag the devs so the fix gets done.
>
> This patch merely detects to see if there was a problem disabling the
> pwm control interfaces. When the user gets an access denied error,
> this is a sure symptom of a problem with the underlying driver. It
> detects this and spits out a warning and instructs the user to let the
> appropriate people know.
I've applied a different fix to the pwmconfig script. A read-only
pwmN_enable file doesn't necessarily mean that the driver is broken.
The device might as well support only one control mode and the only way
to let user-space know what it is is to create a read-only pwmN_enable
file. So I had pwmconfig simply skip PWM outputs that it cannot control.
I have also submitted two patches yesterday that fix the lm85 driver so
that it finally works correctly with pwmconfig. Please test if you can.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next reply other threads:[~2007-12-04 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 10:41 Jean Delvare [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-03-18 19:32 [lm-sensors] pwmconfig patch Straterra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204114154.41279fbc@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.