From: rohara@sourceware.org <rohara@sourceware.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] cluster/gfs-kernel/src/gfs eaops.c
Date: 4 Dec 2007 19:30:27 -0000 [thread overview]
Message-ID: <20071204193027.32342.qmail@sourceware.org> (raw)
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: rohara at sourceware.org 2007-12-04 19:30:27
Modified files:
gfs-kernel/src/gfs: eaops.c
Log message:
BZ 323111
Remove permission() checks from xattrs ops.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/eaops.c.diff?cvsroot=cluster&r1=1.6&r2=1.7
--- cluster/gfs-kernel/src/gfs/eaops.c 2006/07/17 21:38:13 1.6
+++ cluster/gfs-kernel/src/gfs/eaops.c 2007/12/04 19:30:27 1.7
@@ -71,13 +71,6 @@
static int
user_eo_get(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_READ, NULL);
- if (error)
- return error;
- }
-
return gfs_ea_get_i(ip, er);
}
@@ -92,17 +85,6 @@
static int
user_eo_set(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- if (S_ISREG(inode->i_mode) ||
- (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
- } else
- return -EPERM;
- }
-
return gfs_ea_set_i(ip, er);
}
@@ -117,17 +99,6 @@
static int
user_eo_remove(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- {
- struct inode *inode = ip->i_vnode;
- if (S_ISREG(inode->i_mode) ||
- (S_ISDIR(inode->i_mode) && !(inode->i_mode & S_ISVTX))) {
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
- } else
- return -EPERM;
- }
-
return gfs_ea_remove_i(ip, er);
}
@@ -238,11 +209,6 @@
static int
security_eo_get(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_READ, NULL);
- if (error)
- return error;
-
return gfs_ea_get_i(ip, er);
}
@@ -257,11 +223,6 @@
static int
security_eo_set(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
-
return gfs_ea_set_i(ip, er);
}
@@ -276,11 +237,6 @@
static int
security_eo_remove(struct gfs_inode *ip, struct gfs_ea_request *er)
{
- struct inode *inode = ip->i_vnode;
- int error = permission(inode, MAY_WRITE, NULL);
- if (error)
- return error;
-
return gfs_ea_remove_i(ip, er);
}
next reply other threads:[~2007-12-04 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 19:30 rohara [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-30 8:32 [Cluster-devel] cluster/gfs-kernel/src/gfs eaops.c fabbione
2007-12-04 19:28 rohara
2006-11-20 19:15 rohara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204193027.32342.qmail@sourceware.org \
--to=rohara@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.