From: Vitaly Bordug <vitb@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, Timur Tabi <timur@freescale.com>
Subject: Re: ucc_uart: add support for Freescale QUICCEngine UART
Date: Wed, 5 Dec 2007 03:59:35 +0300 [thread overview]
Message-ID: <20071205035935.75088890@kernel.crashing.org> (raw)
In-Reply-To: <200712050056.40543.arnd@arndb.de>
On Wed, 5 Dec 2007 00:56:39 +0100
Arnd Bergmann wrote:
> On Wednesday 05 December 2007, Timur Tabi wrote:
> > Arnd Bergmann wrote:
> >=20
> > > You can argue that the QS is really a DMA device, but in that
> > > case you should convert the driver to use the DMA mapping
> > > interfaces correctly, which I would consider overkill.
> >=20
> > I'm confused. =C2=A0I'm already calling dma_alloc_coherent() and getting
> > a dma_addr_t back. =C2=A0Why do I need to use mapping functions to
> > convert between virtual and physical/bus addresses?
>=20
> No, I'm sorry but I'm the one who was confused. The problem I saw was
> that you return something offset from "bd_phys" as a dma_addr_t. This
> would be a lot easier if you had called it bd_bus or bd_dma instead
> of bd_phys, but your code looks absolutely correct upon closer
> inspection.
>=20
Adding my 2 cents, we already have very similar thing in cpm_uart driver...
> Arnd <><
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
--=20
Sincerely, Vitaly
prev parent reply other threads:[~2007-12-05 0:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 17:51 ucc_uart: add support for Freescale QUICCEngine UART Timur Tabi
2007-12-04 22:13 ` Arnd Bergmann
2007-12-04 22:33 ` Timur Tabi
[not found] ` <200712050037.11489.arnd@arndb.de>
2007-12-05 17:06 ` Timur Tabi
2007-12-04 22:39 ` Timur Tabi
2007-12-04 23:26 ` Arnd Bergmann
2007-12-04 23:32 ` Scott Wood
2007-12-04 23:39 ` Arnd Bergmann
2007-12-04 23:44 ` Scott Wood
2007-12-04 23:47 ` Timur Tabi
2007-12-04 23:56 ` Arnd Bergmann
2007-12-05 0:59 ` Vitaly Bordug [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205035935.75088890@kernel.crashing.org \
--to=vitb@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.