diff for duplicates of <20071205151854.GL4653@ghostprotocols.net> diff --git a/a/1.txt b/N1/1.txt index f8dca0f..1e1638f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,8 +6,9 @@ Em Wed, Dec 05, 2007 at 02:53:09PM +0000, Gerrit Renker escreveu: > | 1. no need to calculate the payload size for non data packets as this > | value won't be used. > | 2. Initialize hcrx->ccid3hcrx_bytes_recv with the payload size when -> | hcrx->ccid3hcrx_state = TFRC_RSTATE_NO_DATA. -> | 3. tfrc_rx_hist_duplicate() is only called when ccid3hcrx_state !> | TFRC_RSTATE_NO_DATA, so it doesn't need to goto the done_receiving +> | hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA. +> | 3. tfrc_rx_hist_duplicate() is only called when ccid3hcrx_state != +> | TFRC_RSTATE_NO_DATA, so it doesn't need to goto the done_receiving > | label (that was removed as this was its only use) as do_feedback > | would always be CCID3_FBACK_NONE and so the test would always fail > | and no feedback would be sent, so just return right there. @@ -21,14 +22,15 @@ Em Wed, Dec 05, 2007 at 02:53:09PM +0000, Gerrit Renker escreveu: > | const u32 ndp = dccp_sk(sk)->dccps_options_received.dccpor_ndp; > | const bool is_data_packet = dccp_data_packet(skb); > | -> | if (unlikely(hcrx->ccid3hcrx_state = TFRC_RSTATE_NO_DATA)) { +> | if (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) { > | if (is_data_packet) { > | const u32 payload = skb->len - dccp_hdr(skb)->dccph_doff * 4; > | do_feedback = FBACK_INITIAL; > | ccid3_hc_rx_set_state(sk, TFRC_RSTATE_DATA); -> | hcrx->ccid3hcrx_s > | hcrx->ccid3hcrx_bytes_recv = payload_size; +> | hcrx->ccid3hcrx_s = +> | hcrx->ccid3hcrx_bytes_recv = payload_size; > -> => Please see other email regarding bytes_recv, but I think you already got that. +> ==> Please see other email regarding bytes_recv, but I think you already got that. > Maybe one could then write > hcrx->ccid3hcrx_s = skb->len - dccp_hdr(skb)->dccph_doff * 4; @@ -64,7 +66,7 @@ OK, I got that. > | > | if (list_empty(&hcrx->ccid3hcrx_li_hist)) { /* no loss so far: p = 0 */ > | const u32 sample = tfrc_rx_hist_sample_rtt(&hcrx->ccid3hcrx_hist, skb); -> => If you like, you could add the original comment here that p=0 if no loss occured, i.e. +> ==> If you like, you could add the original comment here that p=0 if no loss occured, i.e. > /* > * Empty loss history: no loss so far, hence p stays 0. > * Sample RTT values, since an RTT estimate is required for the @@ -86,7 +88,7 @@ done > | update_records: > | tfrc_rx_hist_add_packet(&hcrx->ccid3hcrx_hist, skb, ndp); > | -> => here a jump label is missing. It is not needed by this patch and +> ==> here a jump label is missing. It is not needed by this patch and > above you have replaced it with a return + comment, but it is needed in a later > patch: when a new loss event occurs, the control jumps to `done_receiving' and > sends a feedback packet with type FBACK_PARAM_CHANGE. diff --git a/a/content_digest b/N1/content_digest index 38abf2a..222a715 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,16 @@ "ref\011968535863312-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\011968535864083-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\011968535861091-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\011968535861367-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\020071205141027.GD4653@ghostprotocols.net\0" + "ref\020071205145309.GA10991@gerrit.erg.abdn.ac.uk\0" "From\0Arnaldo Carvalho de Melo <acme@redhat.com>\0" "Subject\0Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes\0" - "Date\0Wed, 05 Dec 2007 15:18:54 +0000\0" - "To\0dccp@vger.kernel.org\0" + "Date\0Wed, 5 Dec 2007 13:18:54 -0200\0" + "To\0Gerrit Renker <gerrit@erg.abdn.ac.uk>" + Arnaldo Carvalho de Melo <acme@redhat.com> + dccp@vger.kernel.org + " netdev@vger.kernel.org\0" "\00:1\0" "b\0" "Em Wed, Dec 05, 2007 at 02:53:09PM +0000, Gerrit Renker escreveu:\n" @@ -13,8 +21,9 @@ "> | 1. no need to calculate the payload size for non data packets as this\n" "> | value won't be used.\n" "> | 2. Initialize hcrx->ccid3hcrx_bytes_recv with the payload size when\n" - "> | hcrx->ccid3hcrx_state = TFRC_RSTATE_NO_DATA.\n" - "> | 3. tfrc_rx_hist_duplicate() is only called when ccid3hcrx_state !> | TFRC_RSTATE_NO_DATA, so it doesn't need to goto the done_receiving\n" + "> | hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA.\n" + "> | 3. tfrc_rx_hist_duplicate() is only called when ccid3hcrx_state !=\n" + "> | TFRC_RSTATE_NO_DATA, so it doesn't need to goto the done_receiving\n" "> | label (that was removed as this was its only use) as do_feedback\n" "> | would always be CCID3_FBACK_NONE and so the test would always fail\n" "> | and no feedback would be sent, so just return right there.\n" @@ -28,14 +37,15 @@ "> | \tconst u32 ndp = dccp_sk(sk)->dccps_options_received.dccpor_ndp;\n" "> | \tconst bool is_data_packet = dccp_data_packet(skb);\n" "> | \n" - "> | \tif (unlikely(hcrx->ccid3hcrx_state = TFRC_RSTATE_NO_DATA)) {\n" + "> | \tif (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) {\n" "> | \t\tif (is_data_packet) {\n" "> | \t\t\tconst u32 payload = skb->len - dccp_hdr(skb)->dccph_doff * 4;\n" "> | \t\t\tdo_feedback = FBACK_INITIAL;\n" "> | \t\t\tccid3_hc_rx_set_state(sk, TFRC_RSTATE_DATA);\n" - "> | \t\t\thcrx->ccid3hcrx_s > | \t\t\t\thcrx->ccid3hcrx_bytes_recv = payload_size;\n" + "> | \t\t\thcrx->ccid3hcrx_s =\n" + "> | \t\t\t\thcrx->ccid3hcrx_bytes_recv = payload_size;\n" "> \n" - "> => Please see other email regarding bytes_recv, but I think you already got that.\n" + "> ==> Please see other email regarding bytes_recv, but I think you already got that.\n" "> Maybe one could then write\n" "> \thcrx->ccid3hcrx_s = skb->len - dccp_hdr(skb)->dccph_doff * 4;\n" "\n" @@ -71,7 +81,7 @@ "> | \n" "> | \tif (list_empty(&hcrx->ccid3hcrx_li_hist)) { /* no loss so far: p = 0 */\n" "> | \t\tconst u32 sample = tfrc_rx_hist_sample_rtt(&hcrx->ccid3hcrx_hist, skb);\n" - "> => If you like, you could add the original comment here that p=0 if no\tloss occured, i.e.\n" + "> ==> If you like, you could add the original comment here that p=0 if no\tloss occured, i.e.\n" "> \t\t/*\n" "> \t\t * Empty loss history: no loss so far, hence p stays 0.\n" "> \t\t * Sample RTT values, since an RTT estimate is required for the\n" @@ -93,7 +103,7 @@ "> | update_records:\t\n" "> | \ttfrc_rx_hist_add_packet(&hcrx->ccid3hcrx_hist, skb, ndp);\n" "> | \n" - "> => here a jump label is missing. It is not needed by this patch and\n" + "> ==> here a jump label is missing. It is not needed by this patch and\n" "> above you have replaced it with a return + comment, but it is needed in a later\n" "> patch: when a new loss event occurs, the control jumps to `done_receiving' and\n" "> sends a feedback packet with type FBACK_PARAM_CHANGE.\n" @@ -130,4 +140,4 @@ "\n" - Arnaldo -dc72ef6d2897bc8edb342d52fadb5d90202808106647c8449f8cd99cdcc934ad +5375531e6aed10dfefde76ba0044ee5d6fee82fc9b24615c206d65f17eb37fd3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.