From: Mike Anderson <andmike@linux.vnet.ibm.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Alasdair G Kergon <agk@redhat.com>
Subject: Re: [PATCH 1/2] add stripe end_io function and event trigger
Date: Wed, 5 Dec 2007 09:57:08 -0800 [thread overview]
Message-ID: <20071205175708.GA12022@linux.vnet.ibm.com> (raw)
In-Reply-To: <D44F48C7D79D2943A073C8FA0F49A3CC01A1DFE8@orsmsx418.amr.corp.intel.com>
Wood, Brian J <brian.j.wood@intel.com> wrote:
> +static void trigger_event(struct work_struct *work)
> +{
> + int i, len;
> + char dev_path[DEV_STR_LEN];
> + struct stripe_c *sc = container_of(work, struct stripe_c,
> kstriped_ws);
It appears your mailer is breaking lines which leads to hand edits prior
to trying to apply the patch.
Your patch also appears to be adding extra whitespace. You want to run
checkpatch.pl prior to sending the patch out and correct all issues
listed.
> + /* Finally as a last check, see if the inode mode is set
>
> + * to be a block device, record error if not */
> + if (!S_ISBLK(inode->i_mode)) {
> + atomic_inc(&(sc->stripe[i].error_count));
> + }
Code comment style and extra bracing.
http://sources.redhat.com/lvm2/wiki/KernelPatchGuidelines
-andmike
--
Michael Anderson
andmike@linux.vnet.ibm.com
next prev parent reply other threads:[~2007-12-05 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 17:36 [PATCH 1/2] add stripe end_io function and event trigger Wood, Brian J
2007-12-05 17:57 ` Mike Anderson [this message]
2007-12-05 19:37 ` [PATCH 1/2] add stripe end_io function and eventtrigger Wood, Brian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205175708.GA12022@linux.vnet.ibm.com \
--to=andmike@linux.vnet.ibm.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.