From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] Fix cpu_is_omap343x()
Date: Wed, 5 Dec 2007 15:10:41 -0800 [thread overview]
Message-ID: <20071205231041.GE4105@atomide.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711281817470.9880@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [071128 17:21]:
>
> cpu_is_omap343x() is missing its setup code, and returns 0 on all platforms -
> including OMAP343x.
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
> ---
> include/asm-arm/arch-omap/cpu.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: linux-omap/include/asm-arm/arch-omap/cpu.h
> ===================================================================
> --- linux-omap.orig/include/asm-arm/arch-omap/cpu.h 2007-11-23 17:46:16.000000000 -0700
> +++ linux-omap/include/asm-arm/arch-omap/cpu.h 2007-11-28 17:59:03.000000000 -0700
> @@ -122,6 +122,7 @@
> #define cpu_is_omap24xx() 0
> #define cpu_is_omap242x() 0
> #define cpu_is_omap243x() 0
> +#define cpu_is_omap34xx() 0
> #define cpu_is_omap343x() 0
>
> #if defined(MULTI_OMAP1)
> @@ -160,9 +161,9 @@
> # endif
> # if defined(CONFIG_ARCH_OMAP34XX)
> # undef cpu_is_omap34xx
> +# undef cpu_is_omap343x
> # define cpu_is_omap34xx() 1
> -# else
> -# define cpu_is_omap34xx() 0
> +# define cpu_is_omap343x() is_omap343x()
> # endif
> #endif
Just for reference, this is already applied in the later cpu.h patch.
Regards,
Tony
prev parent reply other threads:[~2007-12-05 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-29 1:20 [PATCH] Fix cpu_is_omap343x() Paul Walmsley
2007-12-05 23:10 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205231041.GE4105@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.