From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix grub_cpu_idle() declaration
Date: Thu, 6 Dec 2007 12:50:57 +0100 [thread overview]
Message-ID: <20071206115057.GA13758@thorin> (raw)
In-Reply-To: <1195872786.7449.2.camel@dv>
My mistake. Please check that in..
On Fri, Nov 23, 2007 at 09:53:06PM -0500, Pavel Roskin wrote:
> ChangeLog:
>
> * include/grub/i386/time.h: use "void" in the argument list
> of grub_cpu_idle().
> * include/grub/powerpc/time.h: Likewise.
> * include/grub/sparc64/time.h: Likewise.
>
> Index: include/grub/i386/time.h
> ===================================================================
> RCS file: /cvsroot/grub/grub2/include/grub/i386/time.h,v
> retrieving revision 1.2
> diff -u -p -r1.2 time.h
> --- include/grub/i386/time.h 5 Nov 2007 14:54:00 -0000 1.2
> +++ include/grub/i386/time.h 24 Nov 2007 02:34:37 -0000
> @@ -20,7 +20,7 @@
> #define KERNEL_CPU_TIME_HEADER 1
>
> static __inline void
> -grub_cpu_idle ()
> +grub_cpu_idle (void)
> {
> /* FIXME: this can't work untill we handle interrupts. */
> /* __asm__ __volatile__ ("hlt"); */
> Index: include/grub/powerpc/time.h
> ===================================================================
> RCS file: /cvsroot/grub/grub2/include/grub/powerpc/time.h,v
> retrieving revision 1.1
> diff -u -p -r1.1 time.h
> --- include/grub/powerpc/time.h 22 Oct 2007 20:02:16 -0000 1.1
> +++ include/grub/powerpc/time.h 24 Nov 2007 02:34:37 -0000
> @@ -20,7 +20,7 @@
> #define KERNEL_CPU_TIME_HEADER 1
>
> static __inline void
> -grub_cpu_idle ()
> +grub_cpu_idle (void)
> {
> /* FIXME: not implemented */
> }
> Index: include/grub/sparc64/time.h
> ===================================================================
> RCS file: /cvsroot/grub/grub2/include/grub/sparc64/time.h,v
> retrieving revision 1.1
> diff -u -p -r1.1 time.h
> --- include/grub/sparc64/time.h 22 Oct 2007 20:02:16 -0000 1.1
> +++ include/grub/sparc64/time.h 24 Nov 2007 02:34:37 -0000
> @@ -20,7 +20,7 @@
> #define KERNEL_CPU_TIME_HEADER 1
>
> static __inline void
> -grub_cpu_idle ()
> +grub_cpu_idle (void)
> {
> /* FIXME: not implemented */
> }
>
>
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)
prev parent reply other threads:[~2007-12-06 11:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-24 2:53 [PATCH] Fix grub_cpu_idle() declaration Pavel Roskin
2007-12-06 11:50 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071206115057.GA13758@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.