From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1J0Fdy-0002Fp-Em
	for mharc-grub-devel@gnu.org; Thu, 06 Dec 2007 07:15:54 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J0Fdw-0002FE-Qa
	for grub-devel@gnu.org; Thu, 06 Dec 2007 07:15:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J0Fdv-0002EK-7y
	for grub-devel@gnu.org; Thu, 06 Dec 2007 07:15:52 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J0Fdu-0002Dz-UL
	for grub-devel@gnu.org; Thu, 06 Dec 2007 07:15:51 -0500
Received: from aybabtu.com ([69.60.117.155])
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1J0Fdu-00027b-4K
	for grub-devel@gnu.org; Thu, 06 Dec 2007 07:15:50 -0500
Received: from [192.168.10.6] (helo=thorin)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.63) (envelope-from <rmh@aybabtu.com>) id 1J0Fds-0007uW-EX
	for grub-devel@gnu.org; Thu, 06 Dec 2007 13:15:48 +0100
Received: from rmh by thorin with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1J0FdA-0003o6-Fr
	for grub-devel@gnu.org; Thu, 06 Dec 2007 13:15:04 +0100
Date: Thu, 6 Dec 2007 13:15:04 +0100
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20071206121504.GF13758@thorin>
References: <473A0C32.5000001@t-online.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <473A0C32.5000001@t-online.de>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] mkdevicemap for Cygwin
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2007 12:15:53 -0000

On Sun, Nov 18, 2007 at 07:40:15PM +0100, Christian Franke wrote:
>
> No, it did not work because check_device() returned 1 ("exists") on
> (*name == 0). This results in 8 bogus "(hd N)\t\n" lines and wrong N for
> the real devices.
>
> Yes, it would work now, because the patch also fixes this bug :-)

Ok, so in that case you don't need...

> +#ifndef __CYGWIN__
>  static void
>  get_ide_disk_name (char *name, int unit)
>  {
> @@ -213,6 +217,7 @@ get_ide_disk_name (char *name, int unit)
>    *name = 0;
>  #endif
>  }
> +#endif /* __CYGWIN__ */
>  
> [...]
> +#ifndef __CYGWIN__    
>    /* IDE disks.  */
>    for (i = 0; i < 8; i++)
>      {
> @@ -431,6 +440,7 @@ make_device_map (const char *device_map,
>  	  num_hd++;
>  	}
>      }
> +#endif /* __CYGWIN__ */

...because you already fixed the problem in:

> -  /* If DEVICE is empty, just return 1.  */
> +  /* If DEVICE is empty, just return error.  */
>    if (*device == 0)
> -    return 1;
> -  
> +    return 0;

  ?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)