diff for duplicates of <200712061648.24806.arnd@arndb.de> diff --git a/a/1.txt b/N1/1.txt index e69d5f0..5d2d202 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,23 +1,18 @@ On Thursday 06 December 2007, Joachim Fenkes wrote: -> =A0=A0=A0=A0=A0=A0=A0=A0printk(KERN_INFO "eHCA Infiniband Device Driver " -> =A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 =A0 "(Version " HCAD_VERSION ")\n"); -> =A0 -> +=A0=A0=A0=A0=A0=A0=A0/* Autodetect hCall locking -- we can't read the fi= -rmware version -> +=A0=A0=A0=A0=A0=A0=A0 * directly, but we know that starting with POWER6,= - all firmware -> +=A0=A0=A0=A0=A0=A0=A0 * versions are good. -> +=A0=A0=A0=A0=A0=A0=A0 */ -> +=A0=A0=A0=A0=A0=A0=A0if (ehca_lock_hcalls =3D=3D -1) -> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0ehca_lock_hcalls =3D !(cur_= -cpu_spec->cpu_user_features -> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= -=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 & PPC_FEATURE_ARCH_2_05); +> printk(KERN_INFO "eHCA Infiniband Device Driver " +> "(Version " HCAD_VERSION ")\n"); +> +> + /* Autodetect hCall locking -- we can't read the firmware version +> + * directly, but we know that starting with POWER6, all firmware +> + * versions are good. +> + */ +> + if (ehca_lock_hcalls == -1) +> + ehca_lock_hcalls = !(cur_cpu_spec->cpu_user_features +> + & PPC_FEATURE_ARCH_2_05); > + -> =A0=A0=A0=A0=A0=A0=A0=A0ret =3D ehca_create_comp_pool(); -> =A0=A0=A0=A0=A0=A0=A0=A0if (ret) { -> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0ehca_gen_err("Cannot crea= -te comp pool."); +> ret = ehca_create_comp_pool(); +> if (ret) { +> ehca_gen_err("Cannot create comp pool."); We already talked about this yesterday, but I still feel that checking the instruction set of the CPU should not be used to determine whether a diff --git a/a/content_digest b/N1/content_digest index 032880b..9d78201 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,33 +5,29 @@ "To\0linuxppc-dev@ozlabs.org\0" "Cc\0Joachim Fenkes <fenkes@de.ibm.com>" LKML <linux-kernel@vger.kernel.org> + OF-General <general@lists.openfabrics.org> + Roland Dreier <rolandd@cisco.com> OF-EWG <ewg@lists.openfabrics.org> + Stefan Roscher <stefan.roscher@de.ibm.com> Christoph Raisch <raisch@de.ibm.com> - Marcus Eder <meder@de.ibm.com> - OF-General <general@lists.openfabrics.org> - " Stefan Roscher <stefan.roscher@de.ibm.com>\0" + " Marcus Eder <meder@de.ibm.com>\0" "\00:1\0" "b\0" "On Thursday 06 December 2007, Joachim Fenkes wrote:\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0printk(KERN_INFO \"eHCA Infiniband Device Driver \"\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 =A0 \"(Version \" HCAD_VERSION \")\\n\");\n" - "> =A0\n" - "> +=A0=A0=A0=A0=A0=A0=A0/* Autodetect hCall locking -- we can't read the fi=\n" - "rmware version\n" - "> +=A0=A0=A0=A0=A0=A0=A0 * directly, but we know that starting with POWER6,=\n" - " all firmware\n" - "> +=A0=A0=A0=A0=A0=A0=A0 * versions are good.\n" - "> +=A0=A0=A0=A0=A0=A0=A0 */\n" - "> +=A0=A0=A0=A0=A0=A0=A0if (ehca_lock_hcalls =3D=3D -1)\n" - "> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0ehca_lock_hcalls =3D !(cur_=\n" - "cpu_spec->cpu_user_features\n" - "> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=\n" - "=A0=A0=A0=A0=A0=A0=A0 =A0 =A0 & PPC_FEATURE_ARCH_2_05);\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240printk(KERN_INFO \"eHCA Infiniband Device Driver \"\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 \302\240 \302\240 \302\240 \"(Version \" HCAD_VERSION \")\\n\");\n" + "> \302\240\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* Autodetect hCall locking -- we can't read the firmware version\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * directly, but we know that starting with POWER6, all firmware\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 * versions are good.\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240 */\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (ehca_lock_hcalls == -1)\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ehca_lock_hcalls = !(cur_cpu_spec->cpu_user_features\n" + "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 \302\240 \302\240 & PPC_FEATURE_ARCH_2_05);\n" "> +\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0ret =3D ehca_create_comp_pool();\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0if (ret) {\n" - "> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0ehca_gen_err(\"Cannot crea=\n" - "te comp pool.\");\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ret = ehca_create_comp_pool();\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (ret) {\n" + "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ehca_gen_err(\"Cannot create comp pool.\");\n" "\n" "We already talked about this yesterday, but I still feel that checking the\n" "instruction set of the CPU should not be used to determine whether a\n" @@ -48,4 +44,4 @@ "\n" "\tArnd <><" -d85e3e0cbcc73516e319b6305ff099bfcb1d8d58d7c3ad6843d74be1d6b9e1a9 +1a4dc42e57b3f8a73280f25d7754d17c0feee19159c78689aa1cc597342b2353
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.