From: "Daniel P. Berrange" <berrange@redhat.com>
To: John Levon <levon@movementarian.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Fix ioemu compile
Date: Thu, 6 Dec 2007 19:41:04 +0000 [thread overview]
Message-ID: <20071206194104.GH23823@redhat.com> (raw)
In-Reply-To: <20071206193520.GB25639@totally.trollied.org.uk>
On Thu, Dec 06, 2007 at 07:35:20PM +0000, John Levon wrote:
> On Thu, Dec 06, 2007 at 11:31:35AM -0800, john.levon@sun.com wrote:
>
> > serial.c was including another Linux-specific header.
> >
> > Signed-off-by: John Levon <john.levon@sun.com>
> >
> > diff --git a/tools/ioemu/hw/serial.c b/tools/ioemu/hw/serial.c
> > --- a/tools/ioemu/hw/serial.c
> > +++ b/tools/ioemu/hw/serial.c
> > @@ -26,9 +26,15 @@
> > #include <sys/time.h>
> > #include <time.h>
> > #include <assert.h>
> > -#include <asm/termios.h>
>
> Erm, or it looks like just making this be <sys/termios.h> will work too
Definitely. Including asm/ headers directly on Linux is frowned upon.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
next prev parent reply other threads:[~2007-12-06 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 19:31 [PATCH] Fix ioemu compile john.levon
2007-12-06 19:35 ` John Levon
2007-12-06 19:41 ` Daniel P. Berrange [this message]
2007-12-07 9:27 ` Trolle Selander
2007-12-07 11:07 ` Keir Fraser
2007-12-07 11:17 ` Keir Fraser
2007-12-07 12:48 ` John Levon
2007-12-07 14:25 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071206194104.GH23823@redhat.com \
--to=berrange@redhat.com \
--cc=levon@movementarian.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.