From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Subject: [PATCH 3/20] dtc2278: ->io_32bit setting don't have to be identical for master/slave
Date: Sun, 9 Dec 2007 22:08:58 +0100 [thread overview]
Message-ID: <200712092208.58494.bzolnier@gmail.com> (raw)
drive->io_32bit is used per PIO transfer so there is no reason to
require it to be identical for master/slave.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/ide.c | 4 ----
drivers/ide/legacy/dtc2278.c | 7 +------
2 files changed, 1 insertion(+), 10 deletions(-)
Index: b/drivers/ide/ide.c
===================================================================
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -795,10 +795,6 @@ int set_io_32bit(ide_drive_t *drive, int
return -EBUSY;
drive->io_32bit = arg;
-#ifdef CONFIG_BLK_DEV_DTC2278
- if (HWIF(drive)->chipset == ide_dtc2278)
- HWIF(drive)->drives[!drive->select.b.unit].io_32bit = arg;
-#endif /* CONFIG_BLK_DEV_DTC2278 */
spin_unlock_irq(&ide_lock);
Index: b/drivers/ide/legacy/dtc2278.c
===================================================================
--- a/drivers/ide/legacy/dtc2278.c
+++ b/drivers/ide/legacy/dtc2278.c
@@ -34,8 +34,7 @@
* filesystem corrupted with -u1, but under heavy disk load only :-)
*
* This card is now forced to use the "serialize" feature,
- * and irq-unmasking is disallowed. If io_32bit is enabled,
- * it must be done for BOTH drives on each interface.
+ * and irq-unmasking is disallowed.
*
* This code was written for the DTC2278E, but might work with any of these:
*
@@ -87,11 +86,7 @@ static void dtc2278_set_pio_mode(ide_dri
Winbond but does anyone actually care */
}
- /*
- * 32bit I/O has to be enabled for *both* drives at the same time.
- */
drive->io_32bit = 1;
- HWIF(drive)->drives[!drive->select.b.unit].io_32bit = 1;
}
static int __init dtc2278_probe(void)
next reply other threads:[~2007-12-09 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 21:08 Bartlomiej Zolnierkiewicz [this message]
2007-12-09 22:27 ` [PATCH 3/20] dtc2278: ->io_32bit setting don't have to be identical for master/slave Alan Cox
2007-12-09 23:15 ` Bartlomiej Zolnierkiewicz
2007-12-09 23:07 ` Alan Cox
2007-12-09 23:52 ` Bartlomiej Zolnierkiewicz
2007-12-10 0:01 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712092208.58494.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.