From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [TCP]: Bind fackets_out state to highest_sack more tightly
Date: Mon, 10 Dec 2007 15:55:06 -0800 (PST) [thread overview]
Message-ID: <20071210.155506.26256910.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0712101437080.3437@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 10 Dec 2007 14:39:46 +0200 (EET)
> On Mon, 10 Dec 2007, David Miller wrote:
>
> > From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
> > Date: Mon, 10 Dec 2007 14:27:24 +0200 (EET)
> >
> > > Added checks will catch most of the errors if the current
> > > complex fack_count counting logic is flawed somewhere.
> > >
> > > Fackets_out should always be advancable if highest_sack is too
> > > because the fackets_out is nowadays accurate (and obviously it
> > > must be smaller than packets_out).
> > >
> > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> >
> > Applied to net-2.6.25, thanks!
>
> Please get the fack_count fix as well from the mm1 thread before my
> mailbox gets filled with stacktraces :-) :
> http://marc.info/?l=linux-netdev&m=119728952018975&w=2
Done, thanks!
prev parent reply other threads:[~2007-12-10 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 12:27 [PATCH] [TCP]: Bind fackets_out state to highest_sack more tightly Ilpo Järvinen
2007-12-10 12:31 ` David Miller
2007-12-10 12:39 ` Ilpo Järvinen
2007-12-10 23:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071210.155506.26256910.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.