From: Scott Wood <scottwood@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jean Delvare <khali@linux-fr.org>,
linuxppc-dev@ozlabs.org, i2c@lm-sensors.org
Subject: Re: [i2c] [PATCH 0/4] Series to add device tree naming to i2c
Date: Mon, 10 Dec 2007 10:42:55 -0600 [thread overview]
Message-ID: <20071210164255.GA4497@loki.buserror.net> (raw)
In-Reply-To: <1197236326.6563.22.camel@pasglop>
On Mon, Dec 10, 2007 at 08:38:46AM +1100, Benjamin Herrenschmidt wrote:
> The more I think about it, the more I tend to agree that tagging isn't
> necessary and you are right. We should just match the name against the
> "compatible" property of the OF nodes (which mean we need to support
> multiple matches though since "compatible" is a list of strings).
It may not be strictly necessary, but I think it's a good idea not just for
safety reasons, but as an indication to the driver what additional
information it has access to. We could put a match data pointer in the i2c
device, and have it be a valid node pointer if the match was an OF one (and
a device-specific struct for a straight platform device, etc). This could
be useful if a device needs to have more properties than standard
address/type/interrupt for some reason.
-Scott
next prev parent reply other threads:[~2007-12-10 17:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 21:20 [PATCH 0/4] Series to add device tree naming to i2c Jon Smirl
2007-12-03 21:20 ` [PATCH 1/4] Implement module aliasing for i2c to translate from device tree names Jon Smirl
2007-12-03 21:20 ` [PATCH 2/4] Modify several rtc drivers to use the alias names list property of i2c Jon Smirl
2007-12-03 21:20 ` [PATCH 3/4] Convert PowerPC MPC i2c to of_platform_driver from platform_driver Jon Smirl
2007-12-03 21:20 ` [PATCH 4/4] Convert pfc8563 i2c driver from old style to new style Jon Smirl
2007-12-03 23:37 ` [PATCH 0/4] Series to add device tree naming to i2c Olof Johansson
2007-12-03 23:51 ` Scott Wood
2007-12-03 23:52 ` Jon Smirl
2007-12-04 0:04 ` Olof Johansson
2007-12-09 20:24 ` [i2c] " Jon Smirl
2007-12-09 20:39 ` Olof Johansson
2007-12-09 20:46 ` Benjamin Herrenschmidt
2007-12-09 20:57 ` Jon Smirl
2007-12-09 21:13 ` Benjamin Herrenschmidt
2007-12-09 21:35 ` Jon Smirl
2007-12-09 21:38 ` Benjamin Herrenschmidt
2007-12-09 21:46 ` Jon Smirl
2007-12-09 21:53 ` Olof Johansson
2007-12-10 16:42 ` Scott Wood [this message]
2007-12-10 18:06 ` Jon Smirl
2007-12-10 18:37 ` Scott Wood
2007-12-10 18:52 ` Jon Smirl
2007-12-10 20:35 ` Benjamin Herrenschmidt
2007-12-10 20:32 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071210164255.GA4497@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.