From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Carlos Rica <jasampler@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] t7004: test that "git-tag -u" implies "-s"
Date: Tue, 11 Dec 2007 00:22:57 -0500 [thread overview]
Message-ID: <20071211052257.GA350@coredump.intra.peff.net> (raw)
In-Reply-To: <7v63z5j16g.fsf@gitster.siamese.dyndns.org>
On Mon, Dec 10, 2007 at 08:38:31PM -0800, Junio C Hamano wrote:
> +get_tag_header implied-sign $commit commit $time >expect
> +echo 'Another signed tag' >>expect
> +echo '-----BEGIN PGP SIGNATURE-----' >>expect
> +test_expect_success '-u implies signed tag' '
> + git-tag -u CDDE430D -m "Another signed tag" implied-sign &&
> + get_tag_msg implied-sign >actual &&
> + git diff expect actual
> +'
One thing that my original did test but this version doesn't: not only
does -u imply -s, but -u implies -s which implies -a. IOW, using "-u"
will put you in an editor (and a poorly done fix might have gotten this
wrong, but apparently Linus is a super-genius).
Your other two tests look good.
-Peff
prev parent reply other threads:[~2007-12-11 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 4:08 "git tag -u keyname" broken Linus Torvalds
2007-12-11 4:24 ` [PATCH] t7004: test that "git-tag -u" implies "-s" Jeff King
2007-12-11 4:38 ` Junio C Hamano
2007-12-11 5:22 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211052257.GA350@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jasampler@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.