From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Glauber de Oliveira Costa <glommer@gmail.com>
Subject: Re: [PATCH 5/4] x86: fix up asm-x86/pgtable*.h formatting
Date: Tue, 11 Dec 2007 09:54:23 +0100 [thread overview]
Message-ID: <20071211085423.GF20172@elte.hu> (raw)
In-Reply-To: <20071211083413.GA19953@infradead.org>
* Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Dec 10, 2007 at 12:55:33PM -0800, Jeremy Fitzhardinge wrote:
> > +#define set_pte_atomic(pteptr, pteval) set_pte(pteptr,pteval)
> > +#define set_pte_present(mm,addr,ptep,pteval) set_pte_at(mm,addr,ptep,pteval)
> >
> > +#define pte_clear(mm,addr,xp) \
> > + do { \
> > + set_pte_at(mm, addr, xp, __pte(0)); \
> > + } while (0)
> > +
> > #undef pmd_clear
> > +#define pmd_clear(xp) \
> > + do { \
> > + set_pmd(xp, __pmd(0)); \
> > + } while (0)
>
> What about turning these into inline functions to get better type
> checking?
yes, please. That will also trigger and resolve any still present
include file dependency mess. Macros are often used to hack around
unclean include file layouts.
Ingo
next prev parent reply other threads:[~2007-12-11 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 20:55 [PATCH 5/4] x86: fix up asm-x86/pgtable*.h formatting Jeremy Fitzhardinge
2007-12-11 8:34 ` Christoph Hellwig
2007-12-11 8:54 ` Ingo Molnar [this message]
2007-12-11 16:51 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211085423.GF20172@elte.hu \
--to=mingo@elte.hu \
--cc=glommer@gmail.com \
--cc=hch@infradead.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.