All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: James Smart <James.Smart@emulex.com>,
	James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: scsi/lpfc/lpfc_attr.c: bogus code
Date: Tue, 11 Dec 2007 23:20:55 +0100	[thread overview]
Message-ID: <20071211222055.GE14204@stusta.de> (raw)

Commit 2e0fef85e098f6794956b8b80b111179fbb4cbb7 added the folowing code 
to drivers/scsi/lpfc/lpfc_attr.c that was most likely not intended to be 
dead code:

<--  snip  -->

...
lpfc_state_show(struct class_device *cdev, char *buf)
{
...
                switch (vport->port_state) {
                        len += snprintf(buf + len, PAGE_SIZE-len,
                                        "initializing\n");
                        break;
...

<--  snip  -->

Spotted by the GNU C compiler version 3.3.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


             reply	other threads:[~2007-12-11 22:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-11 22:20 Adrian Bunk [this message]
2007-12-12 22:00 ` scsi/lpfc/lpfc_attr.c: bogus code James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071211222055.GE14204@stusta.de \
    --to=bunk@kernel.org \
    --cc=James.Bottomley@SteelEye.com \
    --cc=James.Smart@emulex.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.