From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Capture network traffic to a tcpdump file - updated
Date: Tue, 11 Dec 2007 22:40:56 +0000 [thread overview]
Message-ID: <200712112240.58482.paul@codesourcery.com> (raw)
In-Reply-To: <fb249edb0712111428m4dec1ac9h4f649f5170f064b7@mail.gmail.com>
On Tuesday 11 December 2007, andrzej zaborowski wrote:
> On 10/12/2007, Balazs Attila-Mihaly (Cd-MaN) <x_at_y_or_z@yahoo.com> wrote:
> > Here goes v0.2 for my patch :-)
> > Changes
> > - now the option is a separate command line switch:
> > -net capture,vlan=2,file=test.pcap
> > - it is also available from the monitor
> > - added some more constants / defines to avoid repeating portions of the
> > code
>
> Would it be possible to implement this as simply another vlan client
> that does the logging in it's fd_read callback? I think this would be
> cleaner, we would avoid the special case and an additional condition
> check in every qemu_send_packet().
That's exactly what I was imagining when I suggested making it a -net option.
Paul
next prev parent reply other threads:[~2007-12-11 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-10 10:45 [Qemu-devel] [PATCH] Capture network traffic to a tcpdump file - updated Balazs Attila-Mihaly (Cd-MaN)
2007-12-10 15:36 ` Anthony Liguori
2007-12-10 15:40 ` Johannes Schindelin
2007-12-10 16:29 ` Anthony Liguori
2007-12-10 16:36 ` Johannes Schindelin
2007-12-10 17:53 ` Anthony Liguori
2007-12-10 19:28 ` Johannes Schindelin
2007-12-10 21:56 ` Anthony Liguori
2007-12-10 16:05 ` Paul Brook
2007-12-10 16:15 ` Anthony Liguori
2007-12-11 1:25 ` Thiemo Seufer
2007-12-11 22:28 ` andrzej zaborowski
2007-12-11 22:40 ` Paul Brook [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-10 16:20 Balazs Attila-Mihaly (Cd-MaN)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712112240.58482.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.