From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490AbXLKVth (ORCPT ); Tue, 11 Dec 2007 16:49:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752058AbXLKVt3 (ORCPT ); Tue, 11 Dec 2007 16:49:29 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:53264 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbXLKVt3 (ORCPT ); Tue, 11 Dec 2007 16:49:29 -0500 From: "Rafael J. Wysocki" To: Andrew Morton Subject: Re: + revert-hibernation-enter-platform-hibernation-state-in-a-consistent-way.patch added to -mm tree Date: Tue, 11 Dec 2007 23:08:12 +0100 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: Maxim Levitsky , linux-kernel@vger.kernel.org, pavel@ucw.cz References: <200712110958.lBB9wDJl012816@imap1.linux-foundation.org> <200712111501.13754.maximlevitsky@gmail.com> <20071211124049.44a15ff3.akpm@linux-foundation.org> In-Reply-To: <20071211124049.44a15ff3.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712112308.13553.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, 11 of December 2007, Andrew Morton wrote: > On Tue, 11 Dec 2007 15:01:13 +0200 Maxim Levitsky wrote: > > > On Tuesday 11 December 2007 11:58:09 akpm@linux-foundation.org wrote: > > > > > > The patch titled > > > revert "Hibernation: Enter platform hibernation state in a consistent way" > > > has been added to the -mm tree. Its filename is > > > revert-hibernation-enter-platform-hibernation-state-in-a-consistent-way.patch > > > > > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > > > > > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find > > > out what to do about this > > > > > > ------------------------------------------------------ > > > Subject: revert "Hibernation: Enter platform hibernation state in a consistent way" > > > From: Andrew Morton > > > > > > Revert > > > > > > commit 9cd9a0058dd35268b24fa16795a92c800f4086d4 > > > Author: Rafael J. Wysocki > > > Date: Thu Oct 18 03:04:56 2007 -0700 > > > > > > Hibernation: Enter platform hibernation state in a consistent way > > > > > > Because it causes my t61p's suspend-to-RAM to immediately do a > > > resume-from-RAM. > > Noooo.... > > > > First of all, this commit doesn't touch the S3, so you probably > > mean S4. > > Nope, I meant suspend-to-RAM. The t61p was auto-resuming during > suspend-to-RAM. However I just went in to confirm the fix and the bug (a > regression) has just gone away altogether(!). I'll keep an eye on it. However, please don't revert hibernation-enter-platform-hibernation-state-in-a-consistent-way.patch, as it's needed for the RTC wakealarm and some other things to work and it really, really can't break suspend to RAM. :-) [Or if it does, start looking for a new compiler ...] Thanks, Rafael