From: Dave Jones <davej@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: Mike Miller <mike.miller@hp.com>
Subject: fix cciss locking bug.
Date: Tue, 11 Dec 2007 22:44:18 -0500 [thread overview]
Message-ID: <20071212034418.GA25644@redhat.com> (raw)
do_cciss_intr takes the controller lock on entry,
and if something goes wrong, it calls fail_all_cmds
which tries to take the same lock.
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 7d70496..1c57583 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -2756,6 +2756,7 @@ static irqreturn_t do_cciss_intr(int irq, void *dev_id)
printk(KERN_WARNING
"cciss: controller cciss%d failed, stopping.\n",
h->ctlr);
+ spin_unlock_irqrestore(CCISS_LOCK(h->ctlr), flags);
fail_all_cmds(h->ctlr);
return IRQ_HANDLED;
}
--
http://www.codemonkey.org.uk
reply other threads:[~2007-12-12 3:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212034418.GA25644@redhat.com \
--to=davej@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.