From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1J2ShD-0003H0-Ej for mharc-grub-devel@gnu.org; Wed, 12 Dec 2007 09:36:23 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2ShB-0003Dn-Nm for grub-devel@gnu.org; Wed, 12 Dec 2007 09:36:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2Sh9-00039m-MP for grub-devel@gnu.org; Wed, 12 Dec 2007 09:36:21 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2Sh9-000398-CW for grub-devel@gnu.org; Wed, 12 Dec 2007 09:36:19 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J2Sh9-0003FP-0w for grub-devel@gnu.org; Wed, 12 Dec 2007 09:36:19 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1J2Sh7-0003S3-C5 for grub-devel@gnu.org; Wed, 12 Dec 2007 15:36:18 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1J2Sgy-0001gP-CL for grub-devel@gnu.org; Wed, 12 Dec 2007 15:36:08 +0100 Date: Wed, 12 Dec 2007 15:36:08 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071212143608.GB6180@thorin> References: <200712061419.25555.> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200712061419.25555.> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: New module to detect vmware X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2007 14:36:22 -0000 On Thu, Dec 06, 2007 at 02:19:25PM +0100, Martin Haaß wrote: > Hi all! > I tried to build a module to detect vmware. Attached is the module and a test > grub.cfg > It is basically working though I have some questions: > > can i use the return value of the function (e.g. vmware_detect) to give back a > value or am I supposed to always return something like GRUB_ERR_NONE? > > is there a script to add a module to the makefile or do I have to copy/paste > it? > > if I use this: > if vmware_detect = 1; then set foo=1 else set foo=0 fi > I get syntax error and unknown command in an infinite loop is this expected? > It should not be a problem with my module, as it also happend while testing a > environment variable. > So, is it a problem with my if-syntax? As per GCS, it'd be better if this avoided referring to a propietary product more than necessary for the functionality. How about making this a generic detection command (with a similar interface to the cpuid one), such that detection for other virtual environments (e.g. qemu) can potentially be added? > * VMWARE detection code taken from > * http://chitchat.at.infoseek.co.jp/vmware/backdoor.html Is there any copyright-significant code taken from there? Which license? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)