From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1J2Tld-0006P1-Ax for mharc-grub-devel@gnu.org; Wed, 12 Dec 2007 10:45:01 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2Tlb-0006MZ-EE for grub-devel@gnu.org; Wed, 12 Dec 2007 10:44:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2TlY-0006Gb-RA for grub-devel@gnu.org; Wed, 12 Dec 2007 10:44:57 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2TlX-0006GC-UQ for grub-devel@gnu.org; Wed, 12 Dec 2007 10:44:56 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1J2TlX-0001vN-IG for grub-devel@gnu.org; Wed, 12 Dec 2007 10:44:55 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1J2TlV-0003Yb-V8 for grub-devel@gnu.org; Wed, 12 Dec 2007 16:44:54 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1J2TlP-0002Ii-Ab for grub-devel@gnu.org; Wed, 12 Dec 2007 16:44:47 +0100 Date: Wed, 12 Dec 2007 16:44:47 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20071212154447.GA8783@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Move NTFS compression support to new module ntfscomp X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2007 15:45:00 -0000 On Fri, Nov 30, 2007 at 02:58:11AM +0800, Bean wrote: > Hi, > > This patch move NTFS compression function to a standalone module > ntfscomp. To access NTFS compression file, you just need to load > ntfscomp dynamically: > > insmod ntfscomp > > Compression support is not needed most of the time. In some situation, > the size of kernel image is limited (like rom), and it's nice to be > able to shrink the over-sized ntfs module. Nice. I see that you made some unrelated corrections in your patch, e.g.: - unsigned us; + grub_uint16_t us; could you include these in ChangeLog ? Also, would be nice if you could use inline attachment for patches in the future (I hope it's not a nuissance; I ask because this makes it easier to make context replies). Thank you -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)