From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
RT <linux-rt-users@vger.kernel.org>,
Daniel Walker <dwalker@mvista.com>,
Remy Bohmer <linux@bohmer.net>
Subject: Re: [PATCH RT] Revert Softdisable for simple irqs.
Date: Wed, 12 Dec 2007 19:46:02 +0000 [thread overview]
Message-ID: <20071212194602.GB12913@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0712121436260.21795@gandalf.stny.rr.com>
On Wed, Dec 12, 2007 at 02:40:09PM -0500, Steven Rostedt wrote:
>
> In commit 76d2160147f43f982dfe881404cfde9fd0a9da21 lazy irq disabling
> was implemented, and the simple irq handler had a masking set to it.
>
> Remy Bohmer discovered that some devices in the ARM architecture
> would trigger the mask, but never unmask it. His patch to do the
> unmasking was questioned by Russell King about masking simple irqs
> to begin with. Looking further, it was discovered that the problems
> Remy was seeing was due to improper use of the simple handler by
> devices, and he later submitted patches to fix those. But the issue
> that was uncovered was that the simple handler should never mask.
>
> This patch reverts the masking in the simple handler.
>
> [Note: This version is for the RT patch, and the IRQ_PENDING is needed
> for threaded IRQs]
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Thanks for submitting this.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-12-12 19:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 13:31 [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/will stall forever Remy Bohmer
2007-11-26 13:45 ` Remy Bohmer
2007-11-27 15:11 ` Steven Rostedt
2007-11-27 15:25 ` Daniel Walker
2007-11-27 15:53 ` Daniel Walker
2007-11-28 14:38 ` Remy Bohmer
2007-11-28 15:36 ` Daniel Walker
2007-11-28 17:25 ` Russell King - ARM Linux
2007-11-28 17:25 ` Russell King - ARM Linux
2007-11-28 19:04 ` Steven Rostedt
2007-11-28 20:05 ` Russell King - ARM Linux
2007-11-28 20:16 ` Steven Rostedt
2007-11-28 20:44 ` Daniel Walker
2007-11-28 21:13 ` Steven Rostedt
2007-11-28 23:03 ` Russell King - ARM Linux
2007-11-28 23:19 ` Daniel Walker
2007-11-29 9:04 ` Russell King - ARM Linux
2007-11-29 10:14 ` Remy Bohmer
2007-11-29 10:25 ` Russell King - ARM Linux
2007-11-29 11:27 ` Remy Bohmer
2007-11-29 13:36 ` Russell King - ARM Linux
2007-11-29 13:57 ` Steven Rostedt
2007-11-29 14:18 ` Remy Bohmer
2007-11-29 14:29 ` Russell King - ARM Linux
2007-11-29 15:33 ` Remy Bohmer
2007-11-29 16:20 ` Remy Bohmer
2007-11-29 16:30 ` Steven Rostedt
2007-11-30 21:44 ` Thomas Gleixner
2007-12-12 19:40 ` [PATCH RT] Revert Softdisable for simple irqs Steven Rostedt
2007-12-12 19:46 ` Russell King [this message]
2007-12-12 20:05 ` Remy Bohmer
2007-12-12 20:27 ` Steven Rostedt
2007-12-12 21:38 ` Remy Bohmer
[not found] ` <87bq9fqpoi.fsf@vence.hilman.org>
2007-11-28 14:43 ` [PATCH PREEMPT_RT]: On AT91 ARM: GPIO Interrupt handling can/will stall forever Remy Bohmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212194602.GB12913@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux@bohmer.net \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.