From: Kristoffer Ericson <kristoffer.ericson@gmail.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>,
Dmitry <dmitry.torokhov@gmail.com>,
linux-input-list <linux-input@atrey.karlin.mff.cuni.cz>,
linux-main <linux-kernel@vger.kernel.org>
Subject: Re: [HP6XX/FIX/PATCH] - Fix bad default keymap in HP Jornada 6xx keyboard driver
Date: Wed, 12 Dec 2007 19:54:52 +0100 [thread overview]
Message-ID: <20071212195452.d854ea6f.Kristoffer.ericson@gmail.com> (raw)
In-Reply-To: <20071212184558.GA16129@linux-sh.org>
On Thu, 13 Dec 2007 03:45:58 +0900
Paul Mundt <lethal@linux-sh.org> wrote:
> On Wed, Dec 12, 2007 at 07:22:07PM +0100, Kristoffer Ericson wrote:
> > shortlog:
> > * This patch fixes the HP Jornada 6xx keyboard default keymap which had some bad keymap values. This resulted in wrong
> > key being returned when pressed (example : key y returned 'r').
> > * Also, while we are at it lets arrange the include files in alphabetical order.
> >
> You do realize that the default keymap was written for the Japanese units
> and the Japanese keyboards, right? From the looks of it, you are just
> trying to swap one functional set for another. I can assure you that this
> keymap worked fine on the Japanese units, so calling it a bug is a bit
> misleading.
Mostly true yes. However a few errors entered simply due to me copying the keymap poorly in the initial keymap. So it does infact have 'bug' keys that wouldn't work properly on neither japanese / european / US jornadas. And whatever functional set, this patch fixes those
bugs.
next prev parent reply other threads:[~2007-12-12 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 18:22 [HP6XX/FIX/PATCH] - Fix bad default keymap in HP Jornada 6xx keyboard driver Kristoffer Ericson
2007-12-12 18:45 ` Paul Mundt
2007-12-12 18:54 ` Kristoffer Ericson [this message]
2007-12-16 12:51 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212195452.d854ea6f.Kristoffer.ericson@gmail.com \
--to=kristoffer.ericson@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.