From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Fasheh Date: Wed Dec 12 14:54:33 2007 Subject: [Ocfs2-devel] [RFC] to make files of ocfs2 under sysfs canonical In-Reply-To: <20071212222857.GF16474@kroah.com> References: <4758ca1d.11588c0a.7668.ffff9173@mx.google.com> <20071207051224.GA29246@tasint.org> <91b13c310712062321u7ffe7f9dqbe228d6995ce79e@mail.gmail.com> <20071211190633.GA27037@kroah.com> <91b13c310712111702x76553ed1w94d044e5b5d0506f@mail.gmail.com> <20071212222857.GF16474@kroah.com> Message-ID: <20071212225250.GD28607@ca-server1.us.oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com On Wed, Dec 12, 2007 at 02:28:57PM -0800, Greg KH wrote: > > The sysfs entries of ocfs2 are under /sys/oc2b, but I think they > > generally should be under /sys/fs/oc2b, aren't they? > > Yes, they should be, it looks like someone messed up putting them in the > sysfs root directory. 'o2cb' refers to the stuff in ocfs2_nodemanager, so we wanted to keep it out of the fs namespace (think more "cluster" than "file system"). We felt at the time (and still do) that it was better than polluting /sys/fs/ with non file system related things. Also, I feel that for perspective, I should mention that this layout isn't anything new - we've been doing this for a while. > > But as Joel said, this change will break ocfs2-tools, so the decision > > was not made. > > It should be pretty simple to change the tools to work for both places, > right? Changing a path (or just testing two of them) isn't a big deal, the problem is that existing versions of ocfs2-tools will break very badly. That's clearly unnaceptable for a production file system. --Mark -- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@oracle.com