From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h Date: Thu, 13 Dec 2007 02:31:11 -0800 Message-ID: <20071213023111.30ddc487.akpm@linux-foundation.org> References: <20071209214027.GG9440@joi> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1J2lLm-00036N-Nc for linux-fbdev-devel@lists.sourceforge.net; Thu, 13 Dec 2007 02:31:31 -0800 Received: from smtp2.linux-foundation.org ([207.189.120.14]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1J2lLl-0002A8-HM for linux-fbdev-devel@lists.sourceforge.net; Thu, 13 Dec 2007 02:31:29 -0800 In-Reply-To: <20071209214027.GG9440@joi> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net Content-Type: text/plain; charset="windows-1252" To: Marcin =?UTF-8?B?xZpsdXNhcno=?= Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Antonino Daplas T24gU3VuLCA5IERlYyAyMDA3IDIyOjQwOjMxICswMTAwIE1hcmNpbiDFmmx1c2FyeiA8bWFyY2lu LnNsdXNhcnpAZ21haWwuY29tPiB3cm90ZToKCj4gbG9nbzogbW92ZSBkZWNsYXJhdGlvbnMgb2Yg bG9nb3MgdG8gbGludXhfbG9nby5oCj4gCj4gdGhlcmUgd2FzIGEgbWlzbWF0Y2ggYmV0d2VlbiBl eHRlcm5zIGluIGxvZ28uYyBhbmQgY29kZSBnZW5lcmF0ZWQgYnkgcG5tdG9sb2dvCj4gKG9uIG9s ZCB0cmVlLCB5b3UgbmVlZCB0byBybSBkcml2ZXJzL3ZpZGVvL2xvZ28vbG9nb18qLmMgYmVmb3Jl IGNvbXBpbGF0aW9uKQoKVGhpcyBwYXRjaCAoYWZ0ZXIgSSBmaXhlZCBpdCkga2VlcHMgb24gY2F1 c2luZyB0cm91YmxlOiBtaXNtYXRjaGVzIGJldHdlZW4KdGhlIGhlYWRlciBmaWxlIGRlY2xhcmF0 aW9ucyBhbmQgdGhlIGFjdHVhbCBkZWZpbml0aW9ucyBvZiB0aGUgbG9va3VwCnRhYmxlcy4gIFRo aXMgaGFwcGVucyBhcyBJIGFwcGx5IGFuZCB1bmFwcGx5IHRoZSBwYXRjaC4KCkl0IF9zaG91bGRu J3RfIGhhcHBlbiwgYnV0IHRoZXJlIHdvdWxkIGFwcGVhciB0byBiZSBzb21lIG1pc3NpbmcgbWFr ZWZpbGUKcnVsZXMuICBJIGd1ZXNzIHRoZSBDIGZpbGVzIGFyZW4ndCBiZWluZyByZWdlbmVyYXRl ZCB3aGVuCnNjcmlwdHMvcG5tdG9sb2dvLmMgaGFzIGJlZW4gYWx0ZXJlZCwgc28gdGhlIEMgZmls ZXMgYXJlbid0IG1hdGNoaW5nIHRoZSAKaGVhZGVyIHdoaWNoIHRoaXMgcGF0Y2ggYWx0ZXJzLgoK LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQpTRi5OZXQgZW1haWwgaXMgc3BvbnNvcmVkIGJ5OgpDaGVjayBvdXQg dGhlIG5ldyBTb3VyY2VGb3JnZS5uZXQgTWFya2V0cGxhY2UuCkl0J3MgdGhlIGJlc3QgcGxhY2Ug dG8gYnV5IG9yIHNlbGwgc2VydmljZXMKZm9yIGp1c3QgYWJvdXQgYW55dGhpbmcgT3BlbiBTb3Vy Y2UuCmh0dHA6Ly9hZC5kb3VibGVjbGljay5uZXQvY2xrOzE2NDIxNjIzOTsxMzUwMzAzODt3P2h0 dHA6Ly9zZi5uZXQvbWFya2V0cGxhY2UKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtZmJkZXYtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWZiZGV2 LWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5l dC9saXN0cy9saXN0aW5mby9saW51eC1mYmRldi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761646AbXLMKbm (ORCPT ); Thu, 13 Dec 2007 05:31:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753904AbXLMKbc (ORCPT ); Thu, 13 Dec 2007 05:31:32 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:52200 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757955AbXLMKbb (ORCPT ); Thu, 13 Dec 2007 05:31:31 -0500 Date: Thu, 13 Dec 2007 02:31:11 -0800 From: Andrew Morton To: Marcin =?UTF-8?B?xZpsdXNhcno=?= Cc: linux-kernel@vger.kernel.org, Antonino Daplas , linux-fbdev-devel@lists.sourceforge.net Subject: Re: [PATCH] logo: move declarations of logos to linux_logo.h Message-Id: <20071213023111.30ddc487.akpm@linux-foundation.org> In-Reply-To: <20071209214027.GG9440@joi> References: <20071209214027.GG9440@joi> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz wrote: > logo: move declarations of logos to linux_logo.h > > there was a mismatch between externs in logo.c and code generated by pnmtologo > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation) This patch (after I fixed it) keeps on causing trouble: mismatches between the header file declarations and the actual definitions of the lookup tables. This happens as I apply and unapply the patch. It _shouldn't_ happen, but there would appear to be some missing makefile rules. I guess the C files aren't being regenerated when scripts/pnmtologo.c has been altered, so the C files aren't matching the header which this patch alters.