From: Alexey Dobriyan <adobriyan-3ImXcnM4P+0@public.gmane.org>
To: "Denis V. Lunev" <den-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org>
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org
Subject: Re: [Devel] [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
Date: Thu, 13 Dec 2007 17:47:07 +0300 [thread overview]
Message-ID: <20071213144707.GB6209@localhost.sw.ru> (raw)
In-Reply-To: <20071213141842.GA9939-aPCOdVxUTlgvJsYlp49lxw@public.gmane.org>
On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
> There are to many spaces between type and function name in the declaration
> of fib rules manipulation routines. Eat them and save a couple of lines.
If this patch is going in, it would be nice to get rid of "extern" as
well.
Alexey, who once removed all externs from prototypes
and got 4 seconds compilation speedup.
> --- a/include/net/fib_rules.h
> +++ b/include/net/fib_rules.h
> @@ -101,14 +101,12 @@ static inline u32 frh_get_table(struct fib_rule_hdr *frh, struct nlattr **nla)
> return frh->table;
> }
>
> -extern int fib_rules_register(struct fib_rules_ops *);
> -extern int fib_rules_unregister(struct fib_rules_ops *);
> -extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
> +extern int fib_rules_register(struct fib_rules_ops *);
> +extern int fib_rules_unregister(struct fib_rules_ops *);
> +extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
>
> -extern int fib_rules_lookup(struct fib_rules_ops *,
> - struct flowi *, int flags,
> - struct fib_lookup_arg *);
> -extern int fib_default_rule_add(struct fib_rules_ops *,
> - u32 pref, u32 table,
> - u32 flags);
> +extern int fib_rules_lookup(struct fib_rules_ops *, struct flowi *, int flags,
> + struct fib_lookup_arg *);
> +extern int fib_default_rule_add(struct fib_rules_ops *, u32 pref, u32 table,
> + u32 flags);
> #endif
next prev parent reply other threads:[~2007-12-13 14:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 14:18 [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h Denis V. Lunev
[not found] ` <20071213141842.GA9939-aPCOdVxUTlgvJsYlp49lxw@public.gmane.org>
2007-12-13 14:47 ` Alexey Dobriyan [this message]
2007-12-13 14:49 ` [Devel] " David Miller
2007-12-13 14:50 ` David Miller
2007-12-13 15:01 ` Denis V. Lunev
2007-12-13 15:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213144707.GB6209@localhost.sw.ru \
--to=adobriyan-3imxcnm4p+0@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=den-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.