All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Harper <ryanh-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: PATCH vmx.c: add printk_ratelimit in vmx_intr_assist
Date: Thu, 13 Dec 2007 10:21:10 -0600	[thread overview]
Message-ID: <20071213162110.GJ23913@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Add printk_ratelimit check in front of printk.  This prevents spamming
of the message during 32-bit ubuntu 6.06server install.  Previously, it
would hang during the partition formatting stage.

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org

[-- Attachment #2: ratelimit_prink_in_vmx_intr_assist.patch --]
[-- Type: text/plain, Size: 793 bytes --]

For some guests (ubuntu6.06-server) on intel machines, vmx_inter_assist spams
a message preventing the guest from making forward progress.  Adding in a
ratelimit check prevents the spamming.

Signed-off-by: Ryan Harper <ryanh-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c
index 548e3a5..1c1ad7f 100644
--- a/drivers/kvm/vmx.c
+++ b/drivers/kvm/vmx.c
@@ -2261,7 +2261,8 @@ static void vmx_intr_assist(struct kvm_vcpu *vcpu)
 	if (intr_info_field & INTR_INFO_VALID_MASK) {
 		if (idtv_info_field & INTR_INFO_VALID_MASK) {
 			/* TODO: fault when IDT_Vectoring */
-			printk(KERN_ERR "Fault when IDT_Vectoring\n");
+			if (printk_ratelimit())
+				printk(KERN_ERR "Fault when IDT_Vectoring\n");
 		}
 		if (has_ext_irq)
 			enable_irq_window(vcpu);

[-- Attachment #3: Type: text/plain, Size: 308 bytes --]

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

             reply	other threads:[~2007-12-13 16:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-13 16:21 Ryan Harper [this message]
     [not found] ` <20071213162110.GJ23913-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-12-14 14:43   ` PATCH vmx.c: add printk_ratelimit in vmx_intr_assist Avi Kivity
     [not found]     ` <476296A4.2010407-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-14 15:35       ` Ryan Harper
     [not found]         ` <20071214153527.GK23913-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-12-14 22:13           ` Ryan Harper
     [not found]             ` <20071214221359.GO23913-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-12-14 23:51               ` Ryan Harper
2007-12-18 16:30               ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071213162110.GJ23913@us.ibm.com \
    --to=ryanh-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.