From: Andrew Morton <akpm@linux-foundation.org>
To: "Ed Swierk" <eswierk@arastra.com>
Cc: AAbdulla@nvidia.com, jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [patch 02/10] forcedeth: power down phy when interface is down
Date: Thu, 13 Dec 2007 17:07:21 -0800 [thread overview]
Message-ID: <20071213170721.e71ff79f.akpm@linux-foundation.org> (raw)
In-Reply-To: <e6c711510712131653p3c871115r6e9cf33e0c984772@mail.gmail.com>
On Thu, 13 Dec 2007 16:53:58 -0800
"Ed Swierk" <eswierk@arastra.com> wrote:
> On 12/13/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> > Does this patch actually fix any observeable problem?
>
> Without the patch, ifconfig down leaves the physical link up, which
> confuses datacenter users who expect the link lights both on the NIC
> and the switch to go out when they bring an interface down.
>
> Furthermore, even though the phy is powered on, autonegotiation stops
> working, so a normally gigabit link might suddenly become 100 Mbit
> half-duplex when the interface goes down, and become gigabit when it
> comes up again.
>
OK, thanks, I added that text to the changelog along with Ayaz's objection
and shall continue to bug people with it until we have a fix merged.
next prev parent reply other threads:[~2007-12-14 1:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 0:02 [patch 02/10] forcedeth: power down phy when interface is down akpm
2007-12-14 0:11 ` Ayaz Abdulla
2007-12-14 0:30 ` Andrew Morton
2007-12-14 0:51 ` Brandeburg, Jesse
2007-12-14 0:53 ` Ed Swierk
2007-12-14 1:07 ` Andrew Morton [this message]
2007-12-14 20:30 ` Ayaz Abdulla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213170721.e71ff79f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=AAbdulla@nvidia.com \
--cc=eswierk@arastra.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.