From: "Ed L. Cashin" <ecashin@coraid.com>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk
Subject: Re: [Patch 3/8] Enhanced partition statistics: aoe fix
Date: Thu, 13 Dec 2007 15:08:14 -0500 [thread overview]
Message-ID: <20071213200814.GK30302@coraid.com> (raw)
In-Reply-To: <47615B29.1030108@redhat.com>
On Thu, Dec 13, 2007 at 05:17:45PM +0100, Jerome Marchand wrote:
> Updates the enhanced partition statistics in ATA over Ethernet driver (not tested).
Acked-by: Ed L. Cashin <ecashin@coraid.com>
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
> ---
> aoecmd.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> diff -urNp -X linux-2.6/Documentation/dontdiff linux-2.6.orig/drivers/block/aoe/aoecmd.c linux-2.6/drivers/block/aoe/aoecmd.c
> --- linux-2.6.orig/drivers/block/aoe/aoecmd.c 2007-12-04 17:37:13.000000000 +0100
> +++ linux-2.6/drivers/block/aoe/aoecmd.c 2007-12-05 13:45:10.000000000 +0100
> @@ -648,10 +648,10 @@ aoecmd_ata_rsp(struct sk_buff *skb)
> struct gendisk *disk = d->gd;
> const int rw = bio_data_dir(buf->bio);
>
> - disk_stat_inc(disk, ios[rw]);
> - disk_stat_add(disk, ticks[rw], duration);
> - disk_stat_add(disk, sectors[rw], n_sect);
> - disk_stat_add(disk, io_ticks, duration);
> + all_stat_inc(disk, ios[rw], buf->sector);
> + all_stat_add(disk, ticks[rw], duration, buf->sector);
> + all_stat_add(disk, sectors[rw], n_sect, buf->sector);
> + all_stat_add(disk, io_ticks, duration, buf->sector);
> n = (buf->flags & BUFFL_FAIL) ? -EIO : 0;
> bio_endio(buf->bio, n);
> mempool_free(buf, d->bufpool);
--
Ed L Cashin <ecashin@coraid.com>
prev parent reply other threads:[~2007-12-13 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 16:17 [Patch 3/8] Enhanced partition statistics: aoe fix Jerome Marchand
2007-12-13 20:08 ` Ed L. Cashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213200814.GK30302@coraid.com \
--to=ecashin@coraid.com \
--cc=axboe@kernel.dk \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.