From: Ralf Baechle <ralf@linux-mips.org>
To: Frank Rowand <frank.rowand@am.sony.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] RBTX4927: linux-2.6.24-rc4 hang on boot
Date: Fri, 14 Dec 2007 00:03:48 +0000 [thread overview]
Message-ID: <20071214000348.GA12983@linux-mips.org> (raw)
In-Reply-To: <1197386187.5610.18.camel@localhost.localdomain>
On Tue, Dec 11, 2007 at 10:16:27AM -0500, Frank Rowand wrote:
> In linux-2.6.24-rc4 the Toshiba RBTX4927 hangs on boot.
>
> The cause is that plat_time_init() from arch/mips/tx4927/common/tx4927_setup.c
> does not override the __weak plat_time_init() from arch/mips/kernel/time.c.
> This is due to a compiler bug in gcc 4.1.1. The bug is reported to not exist
> in earlier versions of gcc, and to be fixed in 4.1.2. The problem is that
> the __weak plat_time_init() is empty and thus gets optimized out of
> existence (thus the linker is never given the option to replace the
> __weak function).
You meant the call to plat_time_init() from time_init() gets optimized away.
> For more info on the gcc bug see
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27781
>
> The attached patch is one workaround. Another possible workaround
> would be to change the __weak plat_time_init() to be a non-empty
> function.
The __weak definition of plat_time_init was only ever meant to be a
migration helper to keep platforms that don't have a plat_time_init
compiling. A few greps says that all platforms now supply their own
plat_time_init() so the weak definition is no longer needed. So I
instead delete it.
Ralf
prev parent reply other threads:[~2007-12-14 12:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 15:16 [PATCH] RBTX4927: linux-2.6.24-rc4 hang on boot Frank Rowand
2007-12-14 0:03 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214000348.GA12983@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=frank.rowand@am.sony.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.