From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: <linuxppc-dev@ozlabs.org>
Subject: [PATCH 15/15] [POWERPC] Various fixes to pcibios_enable_device()
Date: Fri, 14 Dec 2007 15:56:15 +1100 [thread overview]
Message-ID: <20071214045621.DECAADE721@ozlabs.org> (raw)
In-Reply-To: <1197608163.200976.87755569596.qpush@grosgo>
Our implementation of pcibios_enable_device() has a couple of problems.
One is that it should not check IORESOURCE_UNSET, as this might be
left dangling after resource assignment (shouldn't but there are
bugs), but instead, we make it check resource->parent which should
be a reliable indication that the resource has been successfully
claimed (it's in the resource tree).
Then, we also need to skip ROM resources that haven't been enabled
as x86 does.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
arch/powerpc/kernel/pci-common.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- linux-merge.orig/arch/powerpc/kernel/pci-common.c 2007-12-14 15:49:34.000000000 +1100
+++ linux-merge/arch/powerpc/kernel/pci-common.c 2007-12-14 15:49:36.000000000 +1100
@@ -1147,7 +1147,10 @@ int pcibios_enable_device(struct pci_dev
r = &dev->resource[idx];
if (!(r->flags & (IORESOURCE_IO | IORESOURCE_MEM)))
continue;
- if (r->flags & IORESOURCE_UNSET) {
+ if ((idx == PCI_ROM_RESOURCE) &&
+ (!(r->flags & IORESOURCE_ROM_ENABLE)))
+ continue;
+ if (r->parent == NULL) {
printk(KERN_ERR "PCI: Device %s not available because"
" of resource collisions\n", pci_name(dev));
return -EINVAL;
prev parent reply other threads:[~2007-12-14 4:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 4:56 [PATCH 0/15] [POWERPC] PCI updates & merges Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 1/15] [POWERPC] pci32: remove bogus alignment message Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 2/15] [POWERPC] pci32: use generic pci_assign_unassign_resources Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 3/15] [POWERPC] pci32: Remove PowerMac P2P bridge IO hack Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 4/15] [POWERPC] pci32: Add flags modifying the PCI code behaviour Benjamin Herrenschmidt
2007-12-14 8:43 ` Olof Johansson
2007-12-14 9:00 ` Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 5/15] [POWERPC] pci32: Remove obsolete PowerMac bus number hack Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 6/15] [POWERPC] pci32: Add platform option to enable /proc PCI domains Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 8/15] [POWERPC] Merge PCI resource fixups Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 7/15] [POWERPC] Merge pcibios_resource_to_bus/bus_to_resource Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 9/15] [POWERPC] Merge PCI resource allocation & assignment Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 10/15] [POWERPC] fix iSeries PCI resource management Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 11/15] [POWERPC] Updates/fixes to 32 bits pcibios_enable_device() Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 12/15] [POWERPC] Merge 32 and 64 bits pcibios_enable_device Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 13/15] [POWERPC] Fixup powermac enable device hook Benjamin Herrenschmidt
2007-12-14 4:56 ` [PATCH 14/15] [POWERPC] Clear pci_probe_only on 64 bits PowerMac Benjamin Herrenschmidt
2007-12-14 4:56 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214045621.DECAADE721@ozlabs.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.