From: "Jose R. Santos" <jrs@us.ibm.com>
To: Andreas Dilger <adilger@sun.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [RFC] [PATCH] Flex_BG ialloc awareness V2.
Date: Fri, 14 Dec 2007 12:07:23 -0600 [thread overview]
Message-ID: <20071214120723.2cf97caa@gara> (raw)
In-Reply-To: <20071214170106.GQ3214@webber.adilger.int>
On Fri, 14 Dec 2007 10:01:06 -0700
Andreas Dilger <adilger@sun.com> wrote:
> Well, I can imagine in some cases that the flexbg will not be completely
> contiguous on disk (e.g. after a filesystem resize, if there are bad
> blocks, etc). As long as the group descriptors themselves are correct
> (i.e. referencing valid bitmaps/itable) then it shouldn't cause a mount
> failure if the per-group data isn't strictly aligned according to the
> superblock flexbg count.
Yes, the meta-data may not be completely contiguous on the disk as per
the definition of flexbg. What I was planing on doing was to check the
first, second and last-1 flexbg to see if how the meta-data is
arranged. If none of those flexbg matches the size of the flexbg size
in the super block the we can set sbi->s_groups_per_flex_shift to zero
which would make the fs fallback to Orlov.
> We would need to validate the group descriptor separately though (e.g.
> group checksums).
Agree
> Cheers, Andreas
> --
> Andreas Dilger
> Sr. Staff Engineer, Lustre Group
> Sun Microsystems of Canada, Inc.
>
-JRS
prev parent reply other threads:[~2007-12-14 18:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 22:10 [RFC] [PATCH] Flex_BG ialloc awareness V2 Jose R. Santos
2007-12-07 10:14 ` Andreas Dilger
2007-12-07 15:52 ` Jose R. Santos
2007-12-11 11:00 ` Andreas Dilger
2007-12-11 16:08 ` Jose R. Santos
2007-12-11 23:15 ` Andreas Dilger
2007-12-13 15:51 ` Jose R. Santos
2007-12-13 22:58 ` Andreas Dilger
2007-12-14 2:36 ` Jose R. Santos
2007-12-14 17:01 ` Andreas Dilger
2007-12-14 18:07 ` Jose R. Santos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214120723.2cf97caa@gara \
--to=jrs@us.ibm.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.