All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: "Catalin Marinas" <catalin.marinas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works
Date: Fri, 14 Dec 2007 17:01:42 +0100	[thread overview]
Message-ID: <200712141701.43914.jnareb@gmail.com> (raw)
In-Reply-To: <b0943d9e0712140626w3a2f55b1i83c33f93d7f8af2f@mail.gmail.com>

On Fri, 14 Dec 2007, Catalin Marinas wrote:
> On 14/12/2007, Jakub Narebski <jnareb@gmail.com> wrote:
>>
>> The command I used quite often in my StGIT workflow, namely
>> "stg refresh -e", which used to refresh patch and launch editor to edit
>> commit (patch) description no longer works in Stacked GIT 0.14.1.
>>
>> I used it when new (refreshed) changes needed also changes in commit
>> description (commit message). Now I have to run two commands:
>> "stg refresh" and "stg edit".
> 
> Well, people complained that 'refresh -e' is misleading and a separate
> command is needed. It's not difficult to move the editing
> functionality out of stgit.commands.edit and re-add the --edit option
> to refresh (while also keeping the separate edit command).

First, the "misleading" part could be corrected by renaming long option
to --edit-description or --edit-message. Second "stg refresh -e" matches
non-StGIT usage of "git commit --amend"; and it is damn useful to have
it as one command, not two. 

> I'm a bit busy with home/family commitments until the new year.

I'll wait. As I am not running StGIT master, but released version,
I would have to waith nevertheless on next release.

TIA
-- 
Jakub Narebski
Poland

      reply	other threads:[~2007-12-14 16:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14 14:07 StGIT: "stg refresh -e/--edit" to refresh patch and edit description no longer works Jakub Narebski
2007-12-14 14:26 ` Catalin Marinas
2007-12-14 16:01   ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712141701.43914.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=catalin.marinas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.