From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] make xfs_idestroy() wait for log I/O to complete
Date: Fri, 14 Dec 2007 20:33:23 +0000 [thread overview]
Message-ID: <20071214203323.GC23564@infradead.org> (raw)
In-Reply-To: <475F8BC3.8020804@sgi.com>
On Wed, Dec 12, 2007 at 06:20:35PM +1100, Lachlan McIlroy wrote:
> An xfs inode can be destroyed before log I/O involving that inode
> is complete. We need to wait for the inode to be unpinned before
> tearing it down. The patch looks big but the only real change is
> adding a call to xfs_iunpin_wait() to the start of xfs_idestroy().
> The rest of the patch is moving xfs_idestroy() after the pinning
> routines.
Making sure the inode is unpinned before it's destroyed definitvely
sounds useful. I can't think of any harm this might cause either.
I'd prefer to have to commits, one to move the function around and one
to add the call to xfs_iunpin_wait, though.
prev parent reply other threads:[~2007-12-14 20:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 7:20 [PATCH] make xfs_idestroy() wait for log I/O to complete Lachlan McIlroy
2007-12-14 20:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071214203323.GC23564@infradead.org \
--to=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.