From: Matt Mackall <mpm@selenic.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off
Date: Sat, 15 Dec 2007 12:12:54 -0600 [thread overview]
Message-ID: <20071215181254.GU17536@waste.org> (raw)
In-Reply-To: <20071215063442.GA26491@gondor.apana.org.au>
On Sat, Dec 15, 2007 at 02:34:42PM +0800, Herbert Xu wrote:
> On Sat, Dec 15, 2007 at 05:31:30PM +1100, Benjamin Herrenschmidt wrote:
> >
> > That's something I've actually never quite liked... the fact that we
> > evaluate the expression anyway. I'm pretty happy with -not- evaluating
> > the expression when CONFIG_BUG is on most of the time since whatever is
> > in there is purely here for the sake of the BUG/WARN test.
>
> Whether we evaluate the expression is a completely different debate.
> I personally agree with you that expressions that have side-effects
> are a stupid idea for either WARN_ON or BUG_ON.
As do I. But we can't really do anything about it short of auditing
them all.
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2007-12-15 18:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 13:27 [PATCH] Make WARN_ON/WARN_ON_ONCE no-ops when CONFIG_BUG is off Herbert Xu
2007-12-14 18:02 ` Matt Mackall
2007-12-15 4:16 ` Herbert Xu
2007-12-15 5:52 ` Matt Mackall
2007-12-15 6:04 ` Herbert Xu
2007-12-15 6:12 ` Matt Mackall
2007-12-15 6:31 ` Herbert Xu
2007-12-15 6:52 ` Herbert Xu
2007-12-15 17:54 ` Matt Mackall
2007-12-15 6:45 ` Dave Jones
2007-12-15 6:22 ` Benjamin Herrenschmidt
2007-12-15 6:31 ` Benjamin Herrenschmidt
2007-12-15 6:34 ` Herbert Xu
2007-12-15 18:12 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071215181254.GU17536@waste.org \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.