All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH] 2.6.24-rc5: Fix build with make O= if the top level Makefile is not present
Date: Sun, 16 Dec 2007 22:50:17 +0100	[thread overview]
Message-ID: <200712162250.18291.rjw@sisk.pl> (raw)

Hi,

IMHO, something like the patch below is needed to fix builds with "make O=",
since after commit 18c32dac75b187d1a4e858f3cfdf03e844129f5e
"kbuild: fix building with O=.. options" the top-level Makefile is no longer
created automatically if it's not present at all.

Thanks,
Rafael


---
From: Rafael J. Wysocki <rjw@sisk.pl>

Make the build system create the top-level Makefile for builds with "make O="
if it is not present already.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 scripts/mkmakefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/scripts/mkmakefile
===================================================================
--- linux-2.6.orig/scripts/mkmakefile
+++ linux-2.6/scripts/mkmakefile
@@ -13,7 +13,7 @@
 test ! -r $2/Makefile -o -O $2/Makefile || exit 0
 # Only overwrite automatically generated Makefiles
 # (so we do not overwrite kernel Makefile)
-if ! grep -q Automatically $2/Makefile
+if (test -f $2/Makefile) && !(grep -q Automatically $2/Makefile)
 then
 	exit 0
 fi

             reply	other threads:[~2007-12-16 21:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16 21:50 Rafael J. Wysocki [this message]
2007-12-16 22:01 ` [PATCH] 2.6.24-rc5: Fix build with make O= if the top level Makefile is not present Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712162250.18291.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.