All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Ortiz <samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
To: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps
Date: Mon, 17 Dec 2007 00:46:51 +0100	[thread overview]
Message-ID: <20071216234933.289314655@sortiz.org> (raw)
In-Reply-To: 20071216234648.774780960@sortiz.org

[-- Attachment #1: irlmp-delete-lsaps-hashbin.diff --]
[-- Type: text/plain, Size: 1178 bytes --]

While testing the mcs7780 based IrDA USB dongle I've stumbled upon
memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in
irlmp_register_link and should probably be freed in irlmp_unregister_link().

Signed-off-by: Hinko Kocevar <hinko.kocevar-oztQky9TsV0CZtS6sZ44uQ@public.gmane.org>
Signed-off-by: Samuel Ortiz <samuel-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>

---
 net/irda/irlmp.c |    1 +
 1 file changed, 1 insertion(+)

Index: net-2.6/net/irda/irlmp.c
===================================================================
--- net-2.6.orig/net/irda/irlmp.c	2007-11-25 05:54:02.000000000 +0100
+++ net-2.6/net/irda/irlmp.c	2007-11-25 07:12:13.000000000 +0100
@@ -353,6 +353,7 @@
 		/* Final cleanup */
 		del_timer(&link->idle_timer);
 		link->magic = 0;
+		hashbin_delete(link->lsaps, (FREE_FUNC) __irlmp_close_lsap);
 		kfree(link);
 	}
 }

-- 


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

  parent reply	other threads:[~2007-12-16 23:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16 23:46 [PATCH 0/5] [IrDA] IrDA net-2.6 fixes Samuel Ortiz
2007-12-16 23:46 ` [PATCH 1/5] [IrDA] Race between open and disconnect in irda-usb Samuel Ortiz
2007-12-16 22:07   ` David Miller
2007-12-16 23:46 ` [PATCH 2/5] [IrDA] mcs7780 needs to free allocated rx buffer Samuel Ortiz
     [not found]   ` <20071216234933.121032143-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2007-12-16 22:08     ` David Miller
2007-12-16 23:46 ` Samuel Ortiz [this message]
     [not found]   ` <20071216234933.289314655-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2007-12-16 22:09     ` [PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps David Miller
2007-12-16 23:46 ` [PATCH 4/5] [IrDA] stir4200 fixes Samuel Ortiz
     [not found]   ` <20071216234933.459646638-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2007-12-16 22:09     ` David Miller
2007-12-16 23:46 ` [PATCH 5/5] [IrDA] irda parameters warning fixes Samuel Ortiz
     [not found]   ` <20071216234933.666730217-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2007-12-16 22:11     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2007-12-03  9:28 [PATCH 0/5] [IrDA] IrDA updates for net-2.6 Samuel Ortiz
2007-12-03  9:28 ` [PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071216234933.289314655@sortiz.org \
    --to=samuel-jcdqhdrhkhmdnm+yrofe0a@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=irda-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.