From: Tony Lindgren <tony@atomide.com>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-omap@vger.kernel.org, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Remove redundant gpio request at apollon
Date: Sun, 16 Dec 2007 16:55:55 -0800 [thread overview]
Message-ID: <20071217005555.GV7388@atomide.com> (raw)
In-Reply-To: <20071206014626.GA15974@party>
* Kyungmin Park <kyungmin.park@samsung.com> [071205 17:46]:
> The gpio request is done by gpio-keys
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/mach-omap2/board-apollon-keys.c b/arch/arm/mach-omap2/board-apollon-keys.c
> index 6b2e551..b6fa4ea 100644
> --- a/arch/arm/mach-omap2/board-apollon-keys.c
> +++ b/arch/arm/mach-omap2/board-apollon-keys.c
> @@ -77,29 +77,17 @@ static void __init apollon_sw_init(void)
> {
> /* Enter SW - Y11 */
> omap_cfg_reg(Y11_242X_GPIO16);
> - omap_request_gpio(SW_ENTER_GPIO16);
> - omap_set_gpio_direction(SW_ENTER_GPIO16, 1);
> /* Up SW - AA12 */
> omap_cfg_reg(AA12_242X_GPIO17);
> - omap_request_gpio(SW_UP_GPIO17);
> - omap_set_gpio_direction(SW_UP_GPIO17, 1);
> /* Down SW - AA8 */
> omap_cfg_reg(AA8_242X_GPIO58);
> - omap_request_gpio(SW_DOWN_GPIO58);
> - omap_set_gpio_direction(SW_DOWN_GPIO58, 1);
> #ifdef CONFIG_MACH_OMAP_APOLLON_PLUS
> /* Left SW - P18 */
> omap_cfg_reg(P18_24XX_GPIO95);
> - omap_request_gpio(SW_LEFT_GPIO95);
> - omap_set_gpio_direction(SW_LEFT_GPIO95, 1);
> /* Right SW - M18 */
> omap_cfg_reg(M18_24XX_GPIO96);
> - omap_request_gpio(SW_RIGHT_GPIO96);
> - omap_set_gpio_direction(SW_RIGHT_GPIO96, 1);
> /* Esc SW - L14 */
> omap_cfg_reg(L14_24XX_GPIO97);
> - omap_request_gpio(SW_ESC_GPIO97);
> - omap_set_gpio_direction(SW_ESC_GPIO97, 1);
> #endif
> }
>
Pushing today.
Tony
prev parent reply other threads:[~2007-12-17 0:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 1:46 [PATCH] ARM: OMAP: Remove redundant gpio request at apollon Kyungmin Park
2007-12-17 0:55 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217005555.GV7388@atomide.com \
--to=tony@atomide.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.