From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [PATCH] Fix xenconsole's "Could not read tty from
	store"
Date: Mon, 17 Dec 2007 16:54:01 +0000
Message-ID: <20071217165401.GS4614@implementation.uk.xensource.com>
References: <20071217112254.GA5240@implementation.uk.xensource.com>
	<20071217164246.GF4172@totally.trollied.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20071217164246.GF4172@totally.trollied.org.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: John Levon <levon@movementarian.org>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

John Levon, le Mon 17 Dec 2007 16:42:46 +0000, a écrit :
> > +	if (tcgetattr(master, &term) < 0) {
> > +		err = errno;
> 
> Please use the slave not the master. It doesn't matter on Linux but it's
> critical on Solaris.

Ok. 

> If it helps I can send out an updated patch merging these fixes. Will
> you test it if so Samuel?

Sure!

Samuel