From mboxrd@z Thu Jan 1 00:00:00 1970 From: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Subject: Re: [PATCH 0/9] Core pid namespace enhancements Date: Mon, 17 Dec 2007 16:52:41 -0800 Message-ID: <20071218005240.GA29444@us.ibm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: Linux Containers , Andrew Morton , Oleg Nesterov , Pavel Emelyanov List-Id: containers.vger.kernel.org Eric W. Biederman [ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org] wrote: | | The following patchset updates the pid namespace infrastructure | so we don't constantly have to worry if we have been called | before or after exit_task_namespaces, by using the pid_namespace | obtained from a processes pid, handles the general case of setting | si_pid in struct sig_info, changes where we drop signals sent to init, | and enhances that changes to also work with the per namespace init. | | Thus resolving most of the big gotchas with the current pid namespace | implementation. | | Eric The patchset looks good to me. My only testcase from the previous set that broke was the case that Oleg pointed out - container-init sets a handler for SIGUSR1 - container-init blocks SIGUSR1 - a descendant of container-init posts SIGUSR1 to container-init - container-init sets SIGUSR1 to SIG_DFL and unblocks and takes the fatal signal. While that discussion can continue... : Sukadev Bhattiprolu