From: Tony Lindgren <tony@atomide.com>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-omap@vger.kernel.org, linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X
Date: Mon, 17 Dec 2007 18:12:38 -0800 [thread overview]
Message-ID: <20071218021238.GC739@atomide.com> (raw)
In-Reply-To: <20071218013301.GA19671@party>
* Kyungmin Park <kyungmin.park@samsung.com> [071217 17:33]:
> Remove undefined CONFIG_ARCH_OMAP242X.
> It boots on locked SRAM board.
>
> Comment from Tony.
> Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be
> needed here. If not selected, the cpu_is_omapxxxx() functions
> are if (0) {} functions and get optimized out.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> diff --git a/arch/arm/plat-omap/sram.c b/arch/arm/plat-omap/sram.c
> index afe8181..c377cb0 100644
> --- a/arch/arm/plat-omap/sram.c
> +++ b/arch/arm/plat-omap/sram.c
> @@ -91,11 +91,9 @@ static int is_sram_locked(void)
> {
> int type = 0;
>
> -#if defined(CONFIG_ARCH_OMAP242X)
> if (cpu_is_omap242x())
> type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
> OMAP2_DEVICETYPE_MASK);
> -#endif
>
> if (type == GP_DEVICE) {
> /* RAMFW: R/W access to all initiators for all qualifier sets */
Pushing today.
Tony
prev parent reply other threads:[~2007-12-18 2:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 1:33 [PATCH] ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X Kyungmin Park
2007-12-18 2:12 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218021238.GC739@atomide.com \
--to=tony@atomide.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-omap-open-source@linux.omap.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.