All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Girish <girishsg@ti.com>
Cc: linux-omap@vger.kernel.org, linux-omap-open-source@linux.omap.com
Subject: Re: [Resending PATCH 1/2] driver:twl4030-rtc specific code
Date: Mon, 17 Dec 2007 21:50:05 -0800	[thread overview]
Message-ID: <20071218055005.GH739@atomide.com> (raw)
In-Reply-To: <02b301c84139$2e7c0480$988818ac@ent.ti.com>

* Girish <girishsg@ti.com> [071217 21:45]:
>  
> Hi Tony,
> 
> >-----Original Message-----
> >From: Tony Lindgren [mailto:tony@atomide.com] 
> 
> >
> >* Girish <girishsg@ti.com> [071216 21:53]:
> >> This patch adds rtc-twl4030 driver specific code.
> >
> >Almost ready.. Just few more things:
> >
> >- Please changes spaces to tabs to follow the CodingStyle
> 
> These spaces din't figure out when I ran checkpatch script, does checkpatch needs an upgrade for such kind of space checks? If yes I
> can try  sending a patch to the maintainer. 

Yeah, checkpatch does not check for that.. I guess it could check for
double spaces and warn about them. Might be a pain to include all the
rules for it though.

> >- Please change the subject to say "RTC: twl4030-rtc specific code"
> 
> I'll resend the patch with above comments fixed.

Thanks, that saves me some re-editing :)

Regards,

Tony

      reply	other threads:[~2007-12-18  5:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17  5:52 [Resending PATCH 1/2] driver:twl4030-rtc specific code Girish
2007-12-17 18:59 ` Tony Lindgren
2007-12-18  5:45   ` Girish
2007-12-18  5:50     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071218055005.GH739@atomide.com \
    --to=tony@atomide.com \
    --cc=girishsg@ti.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.