Re: [PATCH 1/8] powerpc: prpmc2800 - Convert dts file to v1

[David Gibson <david@gibson.dropbear.id.au>]

On Tue, Dec 18, 2007 at 02:35:06PM -0700, Mark A. Greer wrote:
> On Sat, Dec 15, 2007 at 09:03:35AM +1100, David Gibson wrote:
> > On Mon, Dec 10, 2007 at 05:37:38PM -0700, Mark A. Greer wrote:
> > > From: Mark A. Greer <mgreer@mvista.com>
> > > 
> > > Convert the prpmc2800.dts file to dts-v1.  Basically, this means
> > > converting the numeric constants to be 'C'-like (e.g., hexadecimal
> > > numbers start with '0x').
> > 
> > [snip]
> > >  				interrupt-parent = <&/mv64x60/pic>;
> > 
> > If you're converting to dts-v1, you should also convert any path
> > references like this to &{/mv64x60/pic} or else use a label.  Yes,
> > some early dts-v1 supporting dtc versions supported these as is, but
> > the idea is to try to forget that they existed and always require the
> > {} quoting in dts-v1.
> 
> I did convert to use labels in a later patch but it uses <&label> as
> well.  I can change them to &{label} that it appears you are suggesting
> (I haven't tested to see that they work yet though).

&label is fine, it's just &/full/path that needs changing.

I realised you removed all the &/full/path things in a later patch, so
the series as a whole will work.  But this patch alleges to convert to
dts-v1 of itself, but because it fails to requote the path references,
it doesn't.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson