From: Charles Bailey <charles@hashpling.org>
To: Wincent Colaiuta <win@wincent.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix git-instaweb breakage on MacOS X due to the limited sed functionality
Date: Wed, 19 Dec 2007 11:36:17 +0000 [thread overview]
Message-ID: <20071219113617.GA26520@hashpling.org> (raw)
In-Reply-To: <23306E3C-24F1-4626-A956-02531644B786@wincent.com>
On Wed, Dec 19, 2007 at 12:28:04PM +0100, Wincent Colaiuta wrote:
>
> I think it's a bad idea to hard-code the perl path there; the
> generated scripts only assume /usr/bin/perl if the user hasn't
> overridden it at build time:
>
> PERL_PATH=/foo/perl make ...
>
> Using just this should work fine anyway:
>
> perl -p -e ...
>
I agree completely, but all the generated scripts output hard coded
paths so it would seem inconsistent not to qualify the path in this
case too. Would @@PERL_PATH@@perl -p -e work, do you know?
Charles.
next prev parent reply other threads:[~2007-12-19 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 10:57 [PATCH] Fix git-instaweb breakage on MacOS X due to the limited sed functionality Charles Bailey
2007-12-19 11:28 ` Wincent Colaiuta
2007-12-19 11:36 ` Charles Bailey [this message]
2007-12-19 11:43 ` Wincent Colaiuta
2007-12-19 11:48 ` Charles Bailey
2007-12-19 11:53 ` Charles Bailey
2007-12-19 12:23 ` Charles Bailey
2007-12-19 12:25 ` Charles Bailey
2007-12-19 11:55 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071219113617.GA26520@hashpling.org \
--to=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.